Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 14694016: [NaCl] Add support for building using glibc toolchain. (Closed)

Created:
7 years, 7 months ago by Sam Clegg
Modified:
7 years, 7 months ago
Reviewers:
noelallen1, binji
Base URL:
git@github.com:sbc100/cocos2d-x.git@nacl_changes2
Visibility:
Public.

Description

[NaCl] Add support for building using glibc toolchain. BUG= R=binji@chromium.org Committed: https://github.com/sbc100/cocos2d-x/commit/16f9023

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M build-nacl.sh View 1 1 chunk +8 lines, -6 lines 0 comments Download
M cocos2dx/proj.nacl/cocos2dx.mk View 1 2 chunks +13 lines, -0 lines 0 comments Download
M samples/Cpp/HelloCpp/proj.nacl/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M samples/Cpp/SimpleGame/proj.nacl/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M samples/Cpp/TestCpp/proj.nacl/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M samples/Lua/HelloLua/proj.nacl/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M samples/Lua/TestLua/proj.nacl/Makefile View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
7 years, 7 months ago (2013-05-01 23:00:46 UTC) #1
binji
lgtm
7 years, 7 months ago (2013-05-02 01:47:54 UTC) #2
Sam Clegg
7 years, 7 months ago (2013-05-02 19:59:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16f9023 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698