chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc - Issue 14694010: Consolidate manifest handler registration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 14694010: Consolidate manifest handler registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

index 22b8b2a6a934503cd3a61e5f6d0960f830376200..0b4af1f4c08d00489a405cde1a23932208688abc 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

@@ -6,13 +6,8 @@

#include "base/path_service.h"

#include "base/utf_string_conversions.h"

#include "chrome/common/chrome_paths.h"

-#include "chrome/common/extensions/api/extension_action/page_action_handler.h"

-#include "chrome/common/extensions/api/i18n/default_locale_handler.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

-#include "chrome/common/extensions/manifest_handler.h"

-#include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h"

-#include "chrome/common/extensions/manifest_handlers/icons_handler.h"

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

#include "chrome/common/extensions/manifest_url_handler.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -28,15 +23,6 @@ namespace keys = extension_manifest_keys;

namespace extensions {

class InitValueManifestTest : public ExtensionManifestTest {

- protected:

- virtual void SetUp() OVERRIDE {

- ExtensionManifestTest::SetUp();

- (new extensions::DefaultLocaleHandler)->Register();

- (new extensions::IconsHandler)->Register();

- (new extensions::OptionsPageHandler)->Register();

- (new extensions::PageActionHandler)->Register();

- (new extensions::ContentScriptsHandler)->Register();

- }

};

TEST_F(InitValueManifestTest, InitFromValueInvalid) {