Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: chrome/common/extensions/features/base_feature_provider_unittest.cc

Issue 14694010: Consolidate manifest handler registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_unittest.cc ('k') | chrome/common/extensions/manifest_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/features/base_feature_provider_unittest.cc
diff --git a/chrome/common/extensions/features/base_feature_provider_unittest.cc b/chrome/common/extensions/features/base_feature_provider_unittest.cc
index a1de8b57b711fa112045f344b761aea8a2e95477..4b94fb1464bb6ec6d3ff9836cbaab48c5d61c8f9 100644
--- a/chrome/common/extensions/features/base_feature_provider_unittest.cc
+++ b/chrome/common/extensions/features/base_feature_provider_unittest.cc
@@ -4,7 +4,6 @@
#include "chrome/common/extensions/features/base_feature_provider.h"
-#include "chrome/common/extensions/extension_unittest.h"
#include "chrome/common/extensions/features/permission_feature.h"
#include "chrome/common/extensions/value_builder.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -13,10 +12,7 @@ using chrome::VersionInfo;
namespace extensions {
-class BaseFeatureProviderTest : public ExtensionTest {
-};
-
-TEST_F(BaseFeatureProviderTest, ManifestFeatures) {
+TEST(BaseFeatureProviderTest, ManifestFeatures) {
FeatureProvider* provider = BaseFeatureProvider::GetByName("manifest");
SimpleFeature* feature =
static_cast<SimpleFeature*>(provider->GetFeature("description"));
@@ -59,7 +55,7 @@ TEST_F(BaseFeatureProviderTest, ManifestFeatures) {
extension.get(), Feature::UNSPECIFIED_CONTEXT).result());
}
-TEST_F(BaseFeatureProviderTest, PermissionFeatures) {
+TEST(BaseFeatureProviderTest, PermissionFeatures) {
FeatureProvider* provider = BaseFeatureProvider::GetByName("permission");
SimpleFeature* feature =
static_cast<SimpleFeature*>(provider->GetFeature("contextMenus"));
@@ -104,7 +100,7 @@ SimpleFeature* CreatePermissionFeature() {
return new PermissionFeature();
}
-TEST_F(BaseFeatureProviderTest, Validation) {
+TEST(BaseFeatureProviderTest, Validation) {
scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
base::DictionaryValue* feature1 = new base::DictionaryValue();
@@ -139,7 +135,7 @@ TEST_F(BaseFeatureProviderTest, Validation) {
EXPECT_TRUE(provider->GetFeature("feature2"));
}
-TEST_F(BaseFeatureProviderTest, ComplexFeatures) {
+TEST(BaseFeatureProviderTest, ComplexFeatures) {
scoped_ptr<base::DictionaryValue> rule(
DictionaryBuilder()
.Set("feature1",
« no previous file with comments | « chrome/common/extensions/extension_unittest.cc ('k') | chrome/common/extensions/manifest_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698