chrome/common/extensions/api/page_launcher/page_launcher_manifest_unittest.cc - Issue 14694010: Consolidate manifest handler registration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/page_launcher/page_launcher_manifest_unittest.cc

Issue 14694010: Consolidate manifest handler registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc ('k') | chrome/common/extensions/chrome_manifest_handlers.h » ('j') | chrome/common/extensions/chrome_manifest_handlers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/page_launcher/page_launcher_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/page_launcher/page_launcher_manifest_unittest.cc b/chrome/common/extensions/api/page_launcher/page_launcher_manifest_unittest.cc

index 125e033e7ecabf9e92778558187aadb5936d4e4c..d432c4dfcaaec255f3478f16453fb7b07939e617 100644

--- a/chrome/common/extensions/api/page_launcher/page_launcher_manifest_unittest.cc

+++ b/chrome/common/extensions/api/page_launcher/page_launcher_manifest_unittest.cc

@@ -6,7 +6,6 @@

#include "base/compiler_specific.h"

#include "chrome/common/extensions/api/extension_action/action_info.h"

-#include "chrome/common/extensions/api/page_launcher/page_launcher_handler.h"

#include "chrome/common/extensions/background_info.h"

#include "chrome/common/extensions/extension_icon_set.h"

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

@@ -14,13 +13,7 @@

namespace extensions {

class PageLauncherManifestTest : public ExtensionManifestTest {

- virtual void SetUp() OVERRIDE {

- ExtensionManifestTest::SetUp();

- (new PageLauncherHandler)->Register();

- // Required to be recognized as a platform app.

- (new BackgroundManifestHandler)->Register();

- }

+ protected:

virtual char const* test_data_dir() OVERRIDE {

return "page_launcher";

}