chrome/common/extensions/api/commands/commands_manifest_unittest.cc - Issue 14694010: Consolidate manifest handler registration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/commands/commands_manifest_unittest.cc

Issue 14694010: Consolidate manifest handler registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc » ('j') | chrome/common/extensions/chrome_manifest_handlers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/commands/commands_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/commands/commands_manifest_unittest.cc b/chrome/common/extensions/api/commands/commands_manifest_unittest.cc

index c642ebccf3c0f42bb9e48939fb70f3fcb9a0d91c..02d34894169277e6a3df9a227af14dabe3180da9 100644

--- a/chrome/common/extensions/api/commands/commands_manifest_unittest.cc

+++ b/chrome/common/extensions/api/commands/commands_manifest_unittest.cc

@@ -8,7 +8,6 @@

#include "base/string_util.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/api/commands/commands_handler.h"

-#include "chrome/common/extensions/api/extension_action/browser_action_handler.h"

#include "testing/gtest/include/gtest/gtest.h"

namespace errors = extension_manifest_errors;

@@ -16,10 +15,6 @@ namespace errors = extension_manifest_errors;

namespace extensions {

class CommandsManifestTest : public ExtensionManifestTest {

- protected:

- virtual void SetUp() OVERRIDE {

- (new CommandsHandler)->Register();

- }

};

TEST_F(CommandsManifestTest, CommandManifestSimple) {

@@ -86,7 +81,6 @@ TEST_F(CommandsManifestTest, CommandManifestRejectJustShift) {

}

TEST_F(CommandsManifestTest, BrowserActionSynthesizesCommand) {

- (new BrowserActionHandler)->Register();

scoped_refptr<Extension> extension =

LoadAndExpectSuccess("browser_action_synthesizes_command.json");

// An extension with a browser action but no extension command specified