Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5273)

Unified Diff: chrome/browser/extensions/chrome_manifest_parser.cc

Issue 14694010: Consolidate manifest handler registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_manifest_parser.cc
diff --git a/chrome/browser/extensions/chrome_manifest_parser.cc b/chrome/browser/extensions/chrome_manifest_parser.cc
index 9f89bbf86f1d19517c3cc601bf227767355903a0..cb7990372a30a9eb55f0526eb5b423707480b932 100644
--- a/chrome/browser/extensions/chrome_manifest_parser.cc
+++ b/chrome/browser/extensions/chrome_manifest_parser.cc
@@ -8,32 +8,14 @@
#include "chrome/browser/extensions/extension_web_ui.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_notification_types.h"
-#include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"
-#include "chrome/common/extensions/manifest_handlers/icons_handler.h"
-#include "chrome/common/extensions/manifest_handlers/kiosk_enabled_info.h"
-#include "chrome/common/extensions/manifest_handlers/offline_enabled_info.h"
-#include "chrome/common/extensions/manifest_handlers/requirements_handler.h"
-#include "chrome/common/extensions/manifest_handlers/shared_module_info.h"
-#include "chrome/common/extensions/manifest_url_handler.h"
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_service.h"
namespace extensions {
+// TODO(yoz): rename this class
ChromeManifestParser::ChromeManifestParser(Profile* profile)
: profile_(profile) {
- (new AppIsolationHandler)->Register();
- (new DevToolsPageHandler)->Register();
- (new KioskEnabledHandler)->Register();
- (new HomepageURLHandler)->Register();
- (new IconsHandler)->Register();
- (new OfflineEnabledHandler)->Register();
- (new OptionsPageHandler)->Register();
- (new RequirementsHandler)->Register();
- (new SharedModuleHandler)->Register();
- (new UpdateURLHandler)->Register();
- (new URLOverridesHandler)->Register();
-
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,
content::Source<Profile>(profile));
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,

Powered by Google App Engine
This is Rietveld 408576698