Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: pkg/analysis_server/lib/src/services/completion/completion_manager.dart

Issue 1469393003: remove redundant CompletionRequestImpl class (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
index a5e9b6e2edb32308a18ffd18f03f502bcdb98237..c79a9db64da576ad44bf6cd0f4e733159b9e8a25 100644
--- a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
@@ -7,13 +7,10 @@ library services.completion.manager;
import 'dart:async';
import 'package:analysis_server/plugin/protocol/protocol.dart';
-import 'package:analysis_server/src/analysis_server.dart';
-import 'package:analysis_server/src/plugin/server_plugin.dart';
import 'package:analysis_server/src/provisional/completion/completion_core.dart'
show CompletionRequest, CompletionResult;
import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
import 'package:analysis_server/src/services/search/search_engine.dart';
-import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/source.dart';
@@ -218,33 +215,6 @@ class CompletionPerformance {
}
/**
- * Encapsulates information specific to a particular completion request.
- */
-class CompletionRequestImpl implements CompletionRequest {
- /**
- * The underlying analysis server for this completion request.
- */
- final AnalysisServer server;
-
- @override
- final AnalysisContext context;
-
- @override
- final Source source;
-
- @override
- final int offset;
-
- CompletionRequestImpl(this.server, this.context, this.source, this.offset);
-
- @override
- ResourceProvider get resourceProvider => server.resourceProvider;
-
- @override
- ServerPlugin get serverPlugin => server.serverPlugin;
-}
-
-/**
* Code completion result generated by an [CompletionManager].
*/
class CompletionResultImpl implements CompletionResult {

Powered by Google App Engine
This is Rietveld 408576698