Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 1469383004: Run all message tests with a variant that forces preparsing (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Run all message tests with a variant that forces preparsing This will make sure that message tests cover both the parser and preparser paths, just as we do for parsing-related cctests. BUG=v8:4372 LOG=n Committed: https://crrev.com/802ea71e7c1627a934febeee8868ff4344d2dfd1 Cr-Commit-Position: refs/heads/master@{#32307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M test/message/testcfg.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
adamk
machenbach for testrunner, rossberg for whether --min-preparse-length=0 is the right trigger
5 years ago (2015-11-25 00:10:53 UTC) #2
rossberg
lgtm
5 years ago (2015-11-25 17:38:47 UTC) #3
adamk
Thanks for the review. I guess I'll wait for machenbach to return before landing (since ...
5 years ago (2015-11-25 20:02:02 UTC) #4
Michael Achenbach
lgtm - give it a shot. Not sure if there might be unintended effects. You'll ...
5 years ago (2015-11-25 20:44:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469383004/1
5 years ago (2015-11-25 20:46:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 21:02:11 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-25 21:02:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/802ea71e7c1627a934febeee8868ff4344d2dfd1
Cr-Commit-Position: refs/heads/master@{#32307}

Powered by Google App Engine
This is Rietveld 408576698