dart2js: Type inferrence: Account for implicit null test in '??' and '??='.

dart2js: Type inferrence: Account for implicit null test in '??' and '??='.

http://dartbug.com/25043

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/0e4ac0b7e4806dacdd898374f3d3fe0a1533abb0

[sra1, 2015-11-25 22:18:54]

Description was changed from

==========
dart2js: Type inferrence: Account for implicit null test in '??' and '??='.

BUG=http://dartbug.com/25043
==========

to

==========
dart2js: Type inferrence: Account for implicit null test in '??' and '??='.

BUG= http://dartbug.com/25043
==========

[sra1, 2015-11-25 22:19:10]

Description was changed from

==========
dart2js: Type inferrence: Account for implicit null test in '??' and '??='.

BUG= http://dartbug.com/25043
==========

to

==========
dart2js: Type inferrence: Account for implicit null test in '??' and '??='.

http://dartbug.com/25043
==========

[sra1, 2015-11-25 22:22:27]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2015-11-25 22:58:02]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-11-26 02:21:48]

lgtm

https://codereview.chromium.org/1469353008/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/inferrer_visitor.dart (right):

https://codereview.chromium.org/1469353008/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/inferrer_visitor.dart:479: DartType objectType =
compiler.coreTypes.objectType;
delete? (seems unused)

https://codereview.chromium.org/1469353008/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right):

https://codereview.chromium.org/1469353008/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:345: new
NarrowTypeInformation(type, dynamicType.type.nonNullable());
would it be incorrect here to use type.type.nonNullable()?

[sra1, 2015-12-01 02:14:10]

https://chromiumcodereview.appspot.com/1469353008/diff/20001/pkg/compiler/lib...
File pkg/compiler/lib/src/inferrer/inferrer_visitor.dart (right):

https://chromiumcodereview.appspot.com/1469353008/diff/20001/pkg/compiler/lib...
pkg/compiler/lib/src/inferrer/inferrer_visitor.dart:479: DartType objectType =
compiler.coreTypes.objectType;
On 2015/11/26 02:21:48, Siggi Cherem (dart-lang) wrote:
> delete? (seems unused)

Done.

https://chromiumcodereview.appspot.com/1469353008/diff/20001/pkg/compiler/lib...
File pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart (right):

https://chromiumcodereview.appspot.com/1469353008/diff/20001/pkg/compiler/lib...
pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart:345: new
NarrowTypeInformation(type, dynamicType.type.nonNullable());
On 2015/11/26 02:21:48, Siggi Cherem (dart-lang) wrote:
> would it be incorrect here to use type.type.nonNullable()?

I'm not sure what type.type holds at this point for non-exact cases.
The above is clearly correct for all inputs.

[sra1, 2015-12-01 02:19:10]

Description was changed from

==========
dart2js: Type inferrence: Account for implicit null test in '??' and '??='.

http://dartbug.com/25043
==========

to

==========
dart2js: Type inferrence: Account for implicit null test in '??' and '??='.

http://dartbug.com/25043

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0e4ac0b7e4806dacdd898374f3d3fe0a1533abb0
==========

[sra1, 2015-12-01 02:19:11]

Committed patchset #2 (id:40001) manually as
0e4ac0b7e4806dacdd898374f3d3fe0a1533abb0 (presubmit successful).