Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1469353004: Restrict backend misuse (Closed)

Created:
5 years ago by Johnni Winther
Modified:
5 years ago
Reviewers:
sra1, sigurdm
CC:
reviews_dartlang.org, Harry Terkelsen
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix unittests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -99 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +46 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 2 chunks +15 lines, -0 lines 1 comment Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 11 chunks +89 lines, -75 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 2 chunks +8 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/size_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
https://codereview.chromium.org/1469353004/diff/1/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/1469353004/diff/1/pkg/compiler/lib/src/js_backend/backend.dart#newcode584 pkg/compiler/lib/src/js_backend/backend.dart:584: /// The backend must *always* call this method when ...
5 years ago (2015-11-25 13:30:39 UTC) #2
sigurdm
LGTM
5 years ago (2015-11-25 13:41:51 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as ac122ffe921aa27f1f33571c5b0ef3a24f68bfa1 (presubmit successful).
5 years ago (2015-11-25 14:49:51 UTC) #4
sra1
5 years ago (2015-11-25 19:02:13 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1469353004/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend_helpers.dart (right):

https://codereview.chromium.org/1469353004/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend_helpers.dart:696: }
FYI this can be written

MethodElement get objectNoSuchMethod =>
    _objectNoSuchMethod ??=
        coreClasses.objectClass.lookupLocalMember(Identifiers.noSuchMethod_);

Powered by Google App Engine
This is Rietveld 408576698