Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1469323002: SVGPathUtilities tidying (Closed)

Created:
5 years ago by fs
Modified:
5 years ago
Reviewers:
pdr., f(malita)
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SVGPathUtilities tidying Rename buildSVGPathByteStreamFromString to buildByteStreamFromString to be more consistent with other functions (buildStringFromByteStream and buildPathFromByteStream). Also drop the PathParsingMode argument, since it's always UnalteredParsing (and it's unlikely we'll need to build normalized byte streams ATM.) Make buildStringFromByteStream return the resulting String instead of using an out-parameter. Tidies up call-sites and makes for slightly smaller code. BUG=467592 Committed: https://crrev.com/0ca81d5b472b134200ac0d8bc344696cf2185f59 Cr-Commit-Position: refs/heads/master@{#361338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPath.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathUtilities.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathUtilities.cpp View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years ago (2015-11-24 14:19:23 UTC) #2
f(malita)
lgtm
5 years ago (2015-11-24 14:27:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469323002/1
5 years ago (2015-11-24 14:27:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 14:42:09 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-24 14:42:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ca81d5b472b134200ac0d8bc344696cf2185f59
Cr-Commit-Position: refs/heads/master@{#361338}

Powered by Google App Engine
This is Rietveld 408576698