Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: src/compiler/bytecode-graph-builder.cc

Issue 1469303006: Revert of Reland "[Interpreter] Add CreateClosure to BytecodeGraphBuilder." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/bytecode-graph-builder.h" 5 #include "src/compiler/bytecode-graph-builder.h"
6 6
7 #include "src/compiler/linkage.h" 7 #include "src/compiler/linkage.h"
8 #include "src/compiler/operator-properties.h" 8 #include "src/compiler/operator-properties.h"
9 #include "src/interpreter/bytecode-array-iterator.h" 9 #include "src/interpreter/bytecode-array-iterator.h"
10 10
(...skipping 625 matching lines...) Expand 10 before | Expand all | Expand 10 after
636 636
637 637
638 void BytecodeGraphBuilder::VisitPopContext( 638 void BytecodeGraphBuilder::VisitPopContext(
639 const interpreter::BytecodeArrayIterator& iterator) { 639 const interpreter::BytecodeArrayIterator& iterator) {
640 UNIMPLEMENTED(); 640 UNIMPLEMENTED();
641 } 641 }
642 642
643 643
644 void BytecodeGraphBuilder::VisitCreateClosure( 644 void BytecodeGraphBuilder::VisitCreateClosure(
645 const interpreter::BytecodeArrayIterator& iterator) { 645 const interpreter::BytecodeArrayIterator& iterator) {
646 Handle<SharedFunctionInfo> shared_info = 646 UNIMPLEMENTED();
647 Handle<SharedFunctionInfo>::cast(iterator.GetConstantForIndexOperand(0));
648 PretenureFlag tenured =
649 iterator.GetImmediateOperand(1) ? TENURED : NOT_TENURED;
650 const Operator* op = javascript()->CreateClosure(shared_info, tenured);
651 Node* closure = NewNode(op);
652 AddEmptyFrameStateInputs(closure);
653 environment()->BindAccumulator(closure);
654 } 647 }
655 648
656 649
657 void BytecodeGraphBuilder::VisitCreateClosureWide(
658 const interpreter::BytecodeArrayIterator& iterator) {
659 VisitCreateClosure(iterator);
660 }
661
662
663 void BytecodeGraphBuilder::VisitCreateMappedArguments( 650 void BytecodeGraphBuilder::VisitCreateMappedArguments(
664 const interpreter::BytecodeArrayIterator& iterator) { 651 const interpreter::BytecodeArrayIterator& iterator) {
665 UNIMPLEMENTED(); 652 UNIMPLEMENTED();
666 } 653 }
667 654
668 655
669 void BytecodeGraphBuilder::VisitCreateUnmappedArguments( 656 void BytecodeGraphBuilder::VisitCreateUnmappedArguments(
670 const interpreter::BytecodeArrayIterator& iterator) { 657 const interpreter::BytecodeArrayIterator& iterator) {
671 UNIMPLEMENTED(); 658 UNIMPLEMENTED();
672 } 659 }
(...skipping 568 matching lines...) Expand 10 before | Expand all | Expand 10 after
1241 1228
1242 void BytecodeGraphBuilder::UpdateControlDependencyToLeaveFunction(Node* exit) { 1229 void BytecodeGraphBuilder::UpdateControlDependencyToLeaveFunction(Node* exit) {
1243 if (environment()->IsMarkedAsUnreachable()) return; 1230 if (environment()->IsMarkedAsUnreachable()) return;
1244 environment()->MarkAsUnreachable(); 1231 environment()->MarkAsUnreachable();
1245 exit_controls_.push_back(exit); 1232 exit_controls_.push_back(exit);
1246 } 1233 }
1247 1234
1248 } // namespace compiler 1235 } // namespace compiler
1249 } // namespace internal 1236 } // namespace internal
1250 } // namespace v8 1237 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698