DEPS change from issue 988893003

DEPS change from issue 988893003

Since the gn builders do not resolve the DEPS after patch, the patch cannot contain
both the DEPS change as well the usage of the newly added DEPS.

If the CL mentioned in the title does not land, this CL is to be remove/reverted as well.

BUG=v8:4560
LOG=N

Committed: https://crrev.com/bd1943b711b566b758b5f984710c8a998b6bce6f
Cr-Commit-Position: refs/heads/master@{#32296}

[fmeawad, 2015-11-24 20:44:53]

The CQ bit was checked by fmeawad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 20:44:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469303004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469303004/1

[commit-bot: I haz the power, 2015-11-24 20:45:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 20:45:00]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[fmeawad, 2015-11-24 20:46:45]

Description was changed from

==========
DEPS change from issue 988893003

Since the gn builders do not resolve the DEPS after patch, the patch cannot
contain
both the DEPS change as well the usage of the newly added DEPS.

If the CL mentioned in the title does not land, this CL is to be remove/reverted
as well.

BUG=v8:4560
==========

to

==========
DEPS change from issue 988893003

Since the gn builders do not resolve the DEPS after patch, the patch cannot
contain
both the DEPS change as well the usage of the newly added DEPS.

If the CL mentioned in the title does not land, this CL is to be remove/reverted
as well.

BUG=v8:4560
==========

[fmeawad, 2015-11-24 20:46:45]

fmeawad@chromium.org changed reviewers:
+ machenbach@chromium.org

[fmeawad, 2015-11-24 20:51:23]

I am trying to land https://codereview.chromium.org/988893003/ but it fails the
v8_linux_chromium_gn_rel
(http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)
since this CL adds a dependency and uses it at the same time, which is currently
not handled properly by the gn bot.

[Michael Achenbach, 2015-11-25 09:13:28]

lgtm. Note that we have an auto deps roller. If you don't want this deps to be
automatically updated, you need to add it to the blacklist here:
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave...

Otherwise it'll attempt to regularly roll to the same version chromium uses (if
it does), or HEAD of the repo otherwise.

[Michael Achenbach, 2015-11-25 09:15:31]

Please also add this folder to .gitignore just like with other DEPS.

[fmeawad, 2015-11-25 18:40:47]

Description was changed from

==========
DEPS change from issue 988893003

Since the gn builders do not resolve the DEPS after patch, the patch cannot
contain
both the DEPS change as well the usage of the newly added DEPS.

If the CL mentioned in the title does not land, this CL is to be remove/reverted
as well.

BUG=v8:4560
==========

to

==========
DEPS change from issue 988893003

Since the gn builders do not resolve the DEPS after patch, the patch cannot
contain
both the DEPS change as well the usage of the newly added DEPS.

If the CL mentioned in the title does not land, this CL is to be remove/reverted
as well.

BUG=v8:4560
LOG=N
==========

[fmeawad, 2015-11-25 18:41:29]

On 2015/11/25 09:15:31, Michael Achenbach (OOO) wrote:
> Please also add this folder to .gitignore just like with other DEPS.

Done.

[fmeawad, 2015-11-25 18:41:41]

The CQ bit was checked by fmeawad@chromium.org

[fmeawad, 2015-11-25 18:41:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1469303004/#ps40001
(title: "Add the DEPs to gitignore")

[commit-bot: I haz the power, 2015-11-25 18:41:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469303004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469303004/40001

[commit-bot: I haz the power, 2015-11-25 19:22:49]

Description was changed from

==========
DEPS change from issue 988893003

Since the gn builders do not resolve the DEPS after patch, the patch cannot
contain
both the DEPS change as well the usage of the newly added DEPS.

If the CL mentioned in the title does not land, this CL is to be remove/reverted
as well.

BUG=v8:4560
LOG=N
==========

to

==========
DEPS change from issue 988893003

Since the gn builders do not resolve the DEPS after patch, the patch cannot
contain
both the DEPS change as well the usage of the newly added DEPS.

If the CL mentioned in the title does not land, this CL is to be remove/reverted
as well.

BUG=v8:4560
LOG=N
==========

[commit-bot: I haz the power, 2015-11-25 19:22:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-25 19:23:10]

Description was changed from

==========
DEPS change from issue 988893003

Since the gn builders do not resolve the DEPS after patch, the patch cannot
contain
both the DEPS change as well the usage of the newly added DEPS.

If the CL mentioned in the title does not land, this CL is to be remove/reverted
as well.

BUG=v8:4560
LOG=N
==========

to

==========
DEPS change from issue 988893003

Since the gn builders do not resolve the DEPS after patch, the patch cannot
contain
both the DEPS change as well the usage of the newly added DEPS.

If the CL mentioned in the title does not land, this CL is to be remove/reverted
as well.

BUG=v8:4560
LOG=N

Committed: https://crrev.com/bd1943b711b566b758b5f984710c8a998b6bce6f
Cr-Commit-Position: refs/heads/master@{#32296}
==========

[commit-bot: I haz the power, 2015-11-25 19:23:11]

Patchset 3 (id:??) landed as
https://crrev.com/bd1943b711b566b758b5f984710c8a998b6bce6f
Cr-Commit-Position: refs/heads/master@{#32296}