Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 1469283004: PPC: [turbofan] Switch passing of new.target to register. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Switch passing of new.target to register. Port 7c45b005296fc326490a0703add50505518aaa51 Original commit message: This passes the new.target value in a register instead of through a side-channel via the construct stub. Note that only TurboFan code uses the register value so far, but unoptimized code will be switched soon. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4544 LOG=n Committed: https://crrev.com/1c1590e866350a4244da03a148cfe0f0717e5b74 Cr-Commit-Position: refs/heads/master@{#32231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -22 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 6 chunks +20 lines, -11 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 4 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
MTBrandyberry
5 years ago (2015-11-24 19:11:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469283004/1
5 years ago (2015-11-24 20:00:08 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 20:48:32 UTC) #5
michael_dawson
On 2015/11/24 20:48:32, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-11-24 21:16:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469283004/1
5 years ago (2015-11-24 21:24:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 21:29:19 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1c1590e866350a4244da03a148cfe0f0717e5b74 Cr-Commit-Position: refs/heads/master@{#32231}
5 years ago (2015-11-24 21:29:52 UTC) #10
Michael Starzinger
5 years ago (2015-11-24 21:47:18 UTC) #11
Message was sent while issue was closed.
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698