Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 146923002: Revert 246894 "Wire up AGC to the MediaStreamAudioProcessor." (Closed)

Created:
6 years, 11 months ago by MAD
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 246894 "Wire up AGC to the MediaStreamAudioProcessor." It seems to have broken this test: [----------] 1 test from AudioStreamHandlerTest [ RUN ] AudioStreamHandlerTest.ConsecutivePlayRequests ../../media/base/android/media_source_player_unittest.cc:1665: Failure Expected: (first_job) != (second_job), actual: 0x766d4210 vs 0x766d4210 [ FAILED ] MediaSourcePlayerTest.VideoConfigChangeContinuesAcrossSeek (125 ms) [ RUN ] MediaSourcePlayerTest.SeekToThenReleaseThenStart [ OK ] MediaSourcePlayerTest.SeekToThenReleaseThenStart (82 ms) [----------] 8 tests from MediaSourcePlayerTest (590 ms total) > Wire up AGC to the MediaStreamAudioProcessor. > > This CL enables the AGC in the processor based on the constraints, and also trigger SetVolume() in the capturer if the AGC tries to adjust the volume. > > There are also some small changes in the MediaStreamAudioProcessor and its unittest. > > BUG=264611 > TEST= content_unittest --gtest_filter="*MediaStreamAudioProcessor*" > > Review URL: https://codereview.chromium.org/141513006 TBR=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -127 lines) Patch
M trunk/src/content/renderer/media/media_stream_audio_processor.h View 5 chunks +4 lines, -15 lines 0 comments Download
M trunk/src/content/renderer/media/media_stream_audio_processor.cc View 10 chunks +20 lines, -45 lines 0 comments Download
M trunk/src/content/renderer/media/media_stream_audio_processor_options.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/media/media_stream_audio_processor_options.cc View 4 chunks +12 lines, -17 lines 0 comments Download
M trunk/src/content/renderer/media/media_stream_audio_processor_unittest.cc View 3 chunks +1 line, -39 lines 0 comments Download
M trunk/src/content/renderer/media/webrtc_audio_capturer.cc View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
MAD
6 years, 11 months ago (2014-01-24 16:43:15 UTC) #1
MAD
6 years, 11 months ago (2014-01-24 16:43:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r246905 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698