Use invalidation sets for :in-range and :out-of-range.

Use invalidation sets for :in-range and :out-of-range.

Gets rid of a SubtreeStyleChange which relies on sibling tree recalcs.

The changes in expectations for video-mute-repaint.html and
video-unmute-repaint.html are due to the following facts:

* We used to do SubtreeStyleChange for an input whose value changed.
* The video controls have input elements in the UA shadow which are
  modified when the volume is changed.
* Doing the recalc of the input means calling Element::recalcStyle on the
  ancestor chain, which includes the video element, just to reach the
  descendants which need to be recalculated.
* HTMLMediaElement has a didRecalcStyle, which will call updateFromElement
  for LayoutVideo, which in turn does an unconditional
  setShouldDoFullPaintInvalidation.
* Since the whole SubtreeStyleChange -> recalc is gone for the mentioned
  tests, the paint invalidation for LayoutVideo is gone, hence the test
  expectation changes.

R=tkent@chromium.org
BUG=557440
Committed: https://crrev.com/aa8e58a3274d31c25d15f909a2a9190149856b9b
Cr-Commit-Position: refs/heads/master@{#361601}

[rune, 2015-11-24 00:58:05]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 00:59:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469183003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469183003/1

[rune, 2015-11-24 01:02:25]

ptal

[tkent, 2015-11-24 01:19:09]

https://codereview.chromium.org/1469183003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/forms/InputType.cpp (right):

https://codereview.chromium.org/1469183003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/forms/InputType.cpp:568:
element().pseudoStateChanged(CSSSelector::PseudoInRange);
This will work, but I'd like to put pseudoStateChanged calls for PseudoInRange
and PseudoOutOfRange near to pseudoStateChanged for PseudoValid and
PseudoInvalid.
So, putting them into HTMLInputElement::setValueInternal because it calls
setNeedsValidityCheck, which calls pseudoStateChanged for PseudoValid and
PseudoInvalid?

[commit-bot: I haz the power, 2015-11-24 02:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 02:17:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rune, 2015-11-24 08:57:47]

On 2015/11/24 01:19:09, tkent wrote:
>
https://codereview.chromium.org/1469183003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/html/forms/InputType.cpp (right):
> 
>
https://codereview.chromium.org/1469183003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/forms/InputType.cpp:568:
> element().pseudoStateChanged(CSSSelector::PseudoInRange);
> This will work, but I'd like to put pseudoStateChanged calls for PseudoInRange
> and PseudoOutOfRange near to pseudoStateChanged for PseudoValid and
> PseudoInvalid.
> So, putting them into HTMLInputElement::setValueInternal because it calls
> setNeedsValidityCheck, which calls pseudoStateChanged for PseudoValid and
> PseudoInvalid?

Sounds good. This caused a regression in repaint rects for video controls, so I
need to look into that as well.

[rune, 2015-11-24 23:53:39]

Description was changed from

==========
Use invalidation sets for :in-range and :out-of-range.

Gets rid of a SubtreeStyleChange which relies on sibling tree recalcs.

R=tkent@chromium.org
BUG=557440
==========

to

==========
Use invalidation sets for :in-range and :out-of-range.

Gets rid of a SubtreeStyleChange which relies on sibling tree recalcs.

The changes in expectations for video-mute-repaint.html and
video-unmute-repaint.html are due to the following facts:

* We used to do SubtreeStyleChange for an input whose value changed.
* The video controls have input elements in the UA shadow which are
  modified when the volume is changed.
* Doing the recalc of the input means calling Element::recalcStyle on the
  ancestor chain, which includes the video element, just to reach the
  descendants which need to be recalculated.
* HTMLMediaElement has a didRecalcStyle, which will call updateFromElement
  for LayoutVideo, which in turn does an unconditional
  setShouldDoFullPaintInvalidation.
* Since the whole SubtreeStyleChange -> recalc is gone for the mentioned
  tests, the paint invalidation for LayoutVideo is gone, hence the test
  expectation changes.

R=tkent@chromium.org
BUG=557440
==========

[rune, 2015-11-24 23:53:54]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[rune, 2015-11-24 23:57:07]

On 2015/11/24 08:57:47, rune wrote:
> On 2015/11/24 01:19:09, tkent wrote:
> > So, putting them into HTMLInputElement::setValueInternal because it calls
> > setNeedsValidityCheck, which calls pseudoStateChanged for PseudoValid and
> > PseudoInvalid?

Done.

> Sounds good. This caused a regression in repaint rects for video controls, so
I
> need to look into that as well.

I've adjusted the expected results for the video tests and updated the
description to explain what/why.

[commit-bot: I haz the power, 2015-11-24 23:57:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469183003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469183003/20001

[tkent, 2015-11-24 23:59:28]

lgtm

[commit-bot: I haz the power, 2015-11-25 03:09:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 03:09:22]

Dry run: This issue passed the CQ dry run.

[rune, 2015-11-25 07:17:11]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2015-11-25 07:17:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469183003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469183003/20001

[commit-bot: I haz the power, 2015-11-25 07:22:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-25 07:23:42]

Patchset 2 (id:??) landed as
https://crrev.com/aa8e58a3274d31c25d15f909a2a9190149856b9b
Cr-Commit-Position: refs/heads/master@{#361601}

[esprehn, 2015-11-25 07:41:02]

Can you file aa bug for the video causing an unconditional paint on all style
changes? We shouldn't have code like that, it just covers up bugs.

[rune, 2015-11-26 09:04:53]

On 2015/11/25 07:41:02, esprehn wrote:
> Can you file aa bug for the video causing an unconditional paint on all style
> changes? We shouldn't have code like that, it just covers up bugs.

crbug.com/561952