Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1469153004:
Add support for PERF_RECORD_MMAP2 record type (Closed)
DescriptionAdd support for PERF_RECORD_MMAP2 record type
Newer perf.data contains both MMAP and MMAP2 record type,
but MMAP2 record type is not supported in previous ll_prof,
MMAP2 record information will be lost.
BUG=v8:4569
LOG=n
Committed: https://crrev.com/f9bc310e4491efcdf3ff8bf491cf4c61d3cdad7f
Cr-Commit-Position: refs/heads/master@{#32319}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add support for MMAP2 record type #Messages
Total messages: 24 (16 generated)
Description was changed from ========== Add support for PERF_RECORD_MMAP2 record type. Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll-prof, MMAP2 record information will be lost BUG=v8:4569 ========== to ========== Add support for PERF_RECORD_MMAP2 record type. Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll-prof, MMAP2 record information will be lost BUG=v8:4569 ==========
jie.pan@intel.com changed reviewers: + chunyang.dai@intel.com, machenbach@chromium.org, pan.deng@intel.com, weiliang.lin@intel.com
jie.pan@intel.com changed reviewers: - pan.deng@intel.com
jie.pan@intel.com changed reviewers: + pan.deng@intel.com
PERF_RECORD_MMAP2 is not supported in ll-prof, samples in this mmap range will be classified to unaccounted ticks.
[+ ulan] I can only rubber-stamp this. Please make a short first line of the CL description (as this becomes the commit message) and add details in a separate line. https://codereview.chromium.org/1469153004/diff/1/tools/ll_prof.py File tools/ll_prof.py (right): https://codereview.chromium.org/1469153004/diff/1/tools/ll_prof.py#newcode680 tools/ll_prof.py:680: return mmap_info nit: empty line https://codereview.chromium.org/1469153004/diff/1/tools/ll_prof.py#newcode683 tools/ll_prof.py:683: offset + self.header_size) nit: indentation
jie.pan@intel.com changed reviewers: + ulan@chromium.org
format the source code
Description was changed from ========== Add support for PERF_RECORD_MMAP2 record type. Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll-prof, MMAP2 record information will be lost BUG=v8:4569 ========== to ========== Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll-prof, MMAP2 record information will be lost BUG=v8:4569 ==========
Description was changed from ========== Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll-prof, MMAP2 record information will be lost BUG=v8:4569 ========== to ========== Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll-prof, MMAP2 record information will be lost BUG=v8:4569 ==========
Description was changed from ========== Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll-prof, MMAP2 record information will be lost BUG=v8:4569 ========== to ========== Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll-prof, MMAP2 record information will be lost. BUG=v8:4569 ==========
Description was changed from ========== Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll-prof, MMAP2 record information will be lost. BUG=v8:4569 ========== to ========== Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll_prof, MMAP2 record information will be lost. BUG=v8:4569 ==========
Description was changed from ========== Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll_prof, MMAP2 record information will be lost. BUG=v8:4569 ========== to ========== Add support for PERF_RECORD_MMAP2 record type Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll_prof, MMAP2 record information will be lost. BUG=v8:4569 ==========
Description was changed from ========== Add support for PERF_RECORD_MMAP2 record type Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll_prof, MMAP2 record information will be lost. BUG=v8:4569 ========== to ========== Add support for PERF_RECORD_MMAP2 record type Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll_prof, MMAP2 record information will be lost. BUG=v8:4569 LOG=n ==========
lgtm
The CQ bit was checked by jie.pan@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469153004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469153004/20001
The CQ bit was unchecked by jie.pan@intel.com
The CQ bit was checked by jie.pan@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469153004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469153004/20001
Message was sent while issue was closed.
Description was changed from ========== Add support for PERF_RECORD_MMAP2 record type Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll_prof, MMAP2 record information will be lost. BUG=v8:4569 LOG=n ========== to ========== Add support for PERF_RECORD_MMAP2 record type Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll_prof, MMAP2 record information will be lost. BUG=v8:4569 LOG=n ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add support for PERF_RECORD_MMAP2 record type Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll_prof, MMAP2 record information will be lost. BUG=v8:4569 LOG=n ========== to ========== Add support for PERF_RECORD_MMAP2 record type Newer perf.data contains both MMAP and MMAP2 record type, but MMAP2 record type is not supported in previous ll_prof, MMAP2 record information will be lost. BUG=v8:4569 LOG=n Committed: https://crrev.com/f9bc310e4491efcdf3ff8bf491cf4c61d3cdad7f Cr-Commit-Position: refs/heads/master@{#32319} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f9bc310e4491efcdf3ff8bf491cf4c61d3cdad7f Cr-Commit-Position: refs/heads/master@{#32319} |
