Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1469153003: Fix ExtensionWebRequestApiTest.ExtensionRequests test in --isolate-extensions. (Closed)

Created:
5 years ago by lfg
Modified:
5 years ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ExtensionWebRequestApiTest.ExtensionRequests test in --isolate-extensions. Check for the isolate-extensions flag as well as --site-per-process. BUG=532666 Committed: https://crrev.com/d27e959d4cd922eec8b6d11f5e469473e45b4c67 Cr-Commit-Position: refs/heads/master@{#361377}

Patch Set 1 #

Patch Set 2 : oops. fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
lfg
PTAL, thanks!
5 years ago (2015-11-23 22:23:54 UTC) #2
Devlin
lgtm
5 years ago (2015-11-23 22:27:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469153003/1
5 years ago (2015-11-23 22:36:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/33863)
5 years ago (2015-11-23 22:52:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469153003/20001
5 years ago (2015-11-23 23:41:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133194)
5 years ago (2015-11-24 03:13:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469153003/20001
5 years ago (2015-11-24 16:49:43 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 17:14:19 UTC) #15
commit-bot: I haz the power
5 years ago (2015-11-24 17:15:18 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d27e959d4cd922eec8b6d11f5e469473e45b4c67
Cr-Commit-Position: refs/heads/master@{#361377}

Powered by Google App Engine
This is Rietveld 408576698