Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 146913007: Update breakpad to refer to libtest_netscape_plugin.so (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update breakpad to refer to libtest_netscape_plugin.so libTestNetscapePlugIn.so has been renamed to libtest_netscape_plugin.so, sync. R=jochen@chromium.org BUG=341016 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166515

Patch Set 1 #

Patch Set 2 : It's libtest_netscape_plugin.so.. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
sof
Please take a look
6 years, 10 months ago (2014-02-05 13:55:49 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-05 14:14:24 UTC) #2
sof
On 2014/02/05 14:14:24, jochen wrote: > lgtm Sorry, did that in the blind without testing ...
6 years, 10 months ago (2014-02-05 14:21:25 UTC) #3
jochen (gone - plz use gerrit)
Ah, yes, it's libtest_netscape_plugin.so On Feb 5, 2014 3:21 PM, <sigbjornf@opera.com> wrote: > On 2014/02/05 ...
6 years, 10 months ago (2014-02-05 14:25:15 UTC) #4
sof
On 2014/02/05 14:25:15, jochen wrote: > Ah, yes, it's libtest_netscape_plugin.so alright, trying that now.
6 years, 10 months ago (2014-02-05 14:32:16 UTC) #5
sof
On 2014/02/05 14:32:16, sof wrote: > On 2014/02/05 14:25:15, jochen wrote: > > Ah, yes, ...
6 years, 10 months ago (2014-02-05 15:04:58 UTC) #6
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-05 15:05:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/146913007/4
6 years, 10 months ago (2014-02-05 15:05:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 16:11:06 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 10 months ago (2014-02-05 16:11:07 UTC) #10
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-05 17:25:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/146913007/4
6 years, 10 months ago (2014-02-05 17:26:06 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 17:26:18 UTC) #13
Message was sent while issue was closed.
Change committed as 166515

Powered by Google App Engine
This is Rietveld 408576698