Factor ChromeOS specific code out of MetricsLog.

chrome/browser/metrics/metrics_log_chromeos.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/metrics/metrics_log_chromeos.h"
+
+#include "base/prefs/pref_service.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_util.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/common/pref_names.h"
+#include "device/bluetooth/bluetooth_adapter.h"
+#include "device/bluetooth/bluetooth_adapter_factory.h"
+#include "device/bluetooth/bluetooth_device.h"
+
+using metrics::ChromeUserMetricsExtension;
+using metrics::PerfDataProto;
+using metrics::SystemProfileProto;
+typedef SystemProfileProto::Hardware::Bluetooth::PairedDevice PairedDevice;
+
+PairedDevice::Type AsBluetoothDeviceType(
+    enum device::BluetoothDevice::DeviceType device_type) {

[Alexei Svitkine (slow), 2014/01/30 16:30:45]

Nit: I think the "enum" is unnecessary here.

[tdresser, 2014/01/30 18:04:25]

Done.

+  switch (device_type) {
+    case device::BluetoothDevice::DEVICE_UNKNOWN:
+      return PairedDevice::DEVICE_UNKNOWN;
+    case device::BluetoothDevice::DEVICE_COMPUTER:
+      return PairedDevice::DEVICE_COMPUTER;
+    case device::BluetoothDevice::DEVICE_PHONE:
+      return PairedDevice::DEVICE_PHONE;
+    case device::BluetoothDevice::DEVICE_MODEM:
+      return PairedDevice::DEVICE_MODEM;
+    case device::BluetoothDevice::DEVICE_AUDIO:
+      return PairedDevice::DEVICE_AUDIO;
+    case device::BluetoothDevice::DEVICE_CAR_AUDIO:
+      return PairedDevice::DEVICE_CAR_AUDIO;
+    case device::BluetoothDevice::DEVICE_VIDEO:
+      return PairedDevice::DEVICE_VIDEO;
+    case device::BluetoothDevice::DEVICE_PERIPHERAL:
+      return PairedDevice::DEVICE_PERIPHERAL;
+    case device::BluetoothDevice::DEVICE_JOYSTICK:
+      return PairedDevice::DEVICE_JOYSTICK;
+    case device::BluetoothDevice::DEVICE_GAMEPAD:
+      return PairedDevice::DEVICE_GAMEPAD;
+    case device::BluetoothDevice::DEVICE_KEYBOARD:
+      return PairedDevice::DEVICE_KEYBOARD;
+    case device::BluetoothDevice::DEVICE_MOUSE:
+      return PairedDevice::DEVICE_MOUSE;
+    case device::BluetoothDevice::DEVICE_TABLET:
+      return PairedDevice::DEVICE_TABLET;
+    case device::BluetoothDevice::DEVICE_KEYBOARD_MOUSE_COMBO:
+      return PairedDevice::DEVICE_KEYBOARD_MOUSE_COMBO;
+  }
+
+  NOTREACHED();
+  return PairedDevice::DEVICE_UNKNOWN;
+}
+
+MetricsLogChromeOS::~MetricsLogChromeOS() {
+}
+
+MetricsLogChromeOS::MetricsLogChromeOS(ChromeUserMetricsExtension* uma_proto) {
+  UpdateMultiProfileUserCount(uma_proto);
+}
+
+void MetricsLogChromeOS::LogChromeOSMetrics(
+    ChromeUserMetricsExtension* uma_proto) {

[Alexei Svitkine (slow), 2014/01/30 16:30:45]

I would make this take system_profile.

[tdresser, 2014/01/30 18:04:25]

Don't I need the uma_proto to do the add_perf_data() call?
In the most recent patch I pass both (the worst of both worlds).
What do you think I should do here?

+  SystemProfileProto* system_profile = uma_proto->mutable_system_profile();
+  SystemProfileProto::Hardware* hardware = system_profile->mutable_hardware();
+
+  PerfDataProto perf_data_proto;
+  if (perf_provider_.GetPerfData(&perf_data_proto))
+    uma_proto->add_perf_data()->Swap(&perf_data_proto);
+
+  WriteBluetoothProto(hardware);
+  UpdateMultiProfileUserCount(uma_proto);
+}
+
+void MetricsLogChromeOS::WriteRealtimeStabilityAttributes(
+    PrefService* pref, metrics::SystemProfileProto::Stability* stability) {

[Alexei Svitkine (slow), 2014/01/30 16:30:45]

If the first param is on a separate line, it should be 1 param per line.

[tdresser, 2014/01/30 18:04:25]

Done.

+  int count = pref->GetInteger(prefs::kStabilityOtherUserCrashCount);
+  if (count) {
+    stability->set_other_user_crash_count(count);
+    pref->SetInteger(prefs::kStabilityOtherUserCrashCount, 0);
+  }
+
+  count = pref->GetInteger(prefs::kStabilityKernelCrashCount);
+  if (count) {
+    stability->set_kernel_crash_count(count);
+    pref->SetInteger(prefs::kStabilityKernelCrashCount, 0);
+  }
+
+  count = pref->GetInteger(prefs::kStabilitySystemUncleanShutdownCount);
+  if (count) {
+    stability->set_unclean_system_shutdown_count(count);
+    pref->SetInteger(prefs::kStabilitySystemUncleanShutdownCount, 0);
+  }
+}
+
+void MetricsLogChromeOS::WriteBluetoothProto(
+    SystemProfileProto::Hardware* hardware) {
+  // BluetoothAdapterFactory::GetAdapter is synchronous on Chrome OS; if that
+  // changes this will fail at the DCHECK().
+  device::BluetoothAdapterFactory::GetAdapter(
+      base::Bind(&MetricsLogChromeOS::SetBluetoothAdapter,
+                 base::Unretained(this)));
+  DCHECK(adapter_.get());
+
+  SystemProfileProto::Hardware::Bluetooth* bluetooth =
+      hardware->mutable_bluetooth();
+
+  bluetooth->set_is_present(adapter_->IsPresent());
+  bluetooth->set_is_enabled(adapter_->IsPowered());
+
+  device::BluetoothAdapter::DeviceList devices = adapter_->GetDevices();
+  for (device::BluetoothAdapter::DeviceList::iterator iter =
+           devices.begin(); iter != devices.end(); ++iter) {
+    PairedDevice* paired_device = bluetooth->add_paired_device();
+
+    device::BluetoothDevice* device = *iter;
+    paired_device->set_bluetooth_class(device->GetBluetoothClass());
+    paired_device->set_type(AsBluetoothDeviceType(device->GetDeviceType()));
+
+    // address is xx:xx:xx:xx:xx:xx, extract the first three components and
+    // pack into a uint32
+    std::string address = device->GetAddress();
+    if (address.size() > 9 &&
+        address[2] == ':' && address[5] == ':' && address[8] == ':') {
+      std::string vendor_prefix_str;
+      uint64 vendor_prefix;
+
+      base::RemoveChars(address.substr(0, 9), ":", &vendor_prefix_str);
+      DCHECK_EQ(6U, vendor_prefix_str.size());
+      base::HexStringToUInt64(vendor_prefix_str, &vendor_prefix);
+
+      paired_device->set_vendor_prefix(vendor_prefix);
+    }
+
+    paired_device->set_vendor_id(device->GetVendorID());
+    paired_device->set_product_id(device->GetProductID());
+    paired_device->set_device_id(device->GetDeviceID());
+  }
+}
+
+void MetricsLogChromeOS::UpdateMultiProfileUserCount(
+    ChromeUserMetricsExtension* uma_proto) {
+  if (chromeos::UserManager::IsInitialized() &&
+      chromeos::UserManager::Get()->IsMultipleProfilesAllowed()) {
+    uint32 user_count = chromeos::UserManager::Get()

[Alexei Svitkine (slow), 2014/01/30 16:30:45]

Nit: This should probably be a size_t.

[tdresser, 2014/01/30 18:04:25]

Done.

+        ->GetLoggedInUsers().size();
+    SystemProfileProto* system_profile = uma_proto->mutable_system_profile();
+
+    // We invalidate the user count if it changed while the log was open.
+    if (system_profile->has_multi_profile_user_count() &&
+        user_count != system_profile->multi_profile_user_count())

[Alexei Svitkine (slow), 2014/01/30 16:30:45]

Nit: Add {}'s.

[tdresser, 2014/01/30 18:04:25]

Done.

+      user_count = 0;
+
+    system_profile->set_multi_profile_user_count(user_count);
+  }
+}
+
+void MetricsLogChromeOS::SetBluetoothAdapter(
+    scoped_refptr<device::BluetoothAdapter> adapter) {
+  adapter_ = adapter;
+}