Issue 146913004: [Sync] Don't add synced notification app info as core type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146913004: [Sync] Don't add synced notification app info as core type (Closed)

Created:
6 years, 10 months ago by Nicolas Zea

Modified:
6 years, 10 months ago

Reviewers:
Pete Williamson

CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Sync] Don't enable synced notification app info by default Core types don't respect off by default state yet. TBR=petewil@chromium.org BUG=339094, 280266 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247759

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sync/syncable/model_type.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/146913004/1

6 years, 10 months ago (2014-01-29 17:16:45 UTC) #2

Message was sent while issue was closed.

lgtm