Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1469113006: Moving datahopper_internal to JSON JWT service account. (Closed)

Created:
5 years ago by jcgregorio
Modified:
4 years, 12 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Moving datahopper_internal to JSON JWT service account. BUG=skia:4589 Committed: https://skia.googlesource.com/buildbot/+/c93f01fab4720750ebd2552a9a529d8776c80bfb

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M datahopper_internal/go/datahopper_internal/main.go View 1 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
jcgregorio
5 years ago (2015-11-30 13:42:24 UTC) #2
borenet
LGTM for whenever this becomes OK to commit. FTR, you can use the "COMMIT=false" keyword ...
5 years ago (2015-11-30 14:23:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469113006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469113006/20001
4 years, 12 months ago (2015-12-26 15:45:26 UTC) #13
commit-bot: I haz the power
4 years, 12 months ago (2015-12-26 15:48:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/c93f01fab4720750ebd2552a9a529d8776c8...

Powered by Google App Engine
This is Rietveld 408576698