Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1469113004: GN(Android): Fix incremental install when manifest has short-hand app name. (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(Android): Fix incremental install when manifest has short-hand app name. This is the case for ContentShell.apk BUG= Committed: https://crrev.com/b930375d46fb44dad4b91791536b79bb89271ed0 Cr-Commit-Position: refs/heads/master@{#361359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java View 4 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
agrieve
On 2015/11/23 21:34:58, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org ♞
5 years, 1 month ago (2015-11-23 21:35:10 UTC) #3
Yaron
lgtm
5 years ago (2015-11-24 16:11:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469113004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469113004/1
5 years ago (2015-11-24 16:15:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 16:30:25 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-24 16:31:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b930375d46fb44dad4b91791536b79bb89271ed0
Cr-Commit-Position: refs/heads/master@{#361359}

Powered by Google App Engine
This is Rietveld 408576698