Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 14691006: Move SpawnedTestServer to its own subdirectory. (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.
Modified:
7 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, asanka, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, gideonwald, chrome-speed-team+watch_google.com, sail+watch_chromium.org, ajwong+watch_chromium.org, markusheintz_, kinuko+watch, joi+watch-content_chromium.org, cbentzel+watch_chromium.org, vsevik, melevin+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, dominich, marja+watch_chromium.org, darin-cc_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), creis+watch_chromium.org, Raghu Simha, feature-media-reviews_chromium.org, haitaol1, Jered, akalin, tfarina, sreeram, yurys, Aaron Boodman, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Move SpawnedTestServer to its own subdirectory. This is a part of replacing most usages of the Python test server with an in-process C++ test server that should be easier to debug. BUG=96594 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198783

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : sort gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -2333 lines) Patch
M chrome/browser/browser_keyevents_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_switches_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/collected_cookies_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/script_badge_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/stubs_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_extension_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/multipart_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/redirect_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobars_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/loadtimes_extension_bindings_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/connection_tester_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/cookie_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/ftp_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/http_pipelining_compatibility_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/load_timing_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/network_stats_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/proxy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/websocket_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/test/local_policy_test_server.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/test/local_policy_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/repost_form_warning_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/local_safebrowsing_test_server.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/local_safebrowsing_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/local_two_phase_testserver.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/local_two_phase_testserver.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/view_source_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/mach_ports_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_internals_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/session_history_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/test/worker_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 1 2 3 chunks +15 lines, -15 lines 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_openssl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/test/base_test_server.h View 1 chunk +0 lines, -259 lines 0 comments Download
D net/test/base_test_server.cc View 1 chunk +0 lines, -399 lines 0 comments Download
D net/test/local_test_server.h View 1 chunk +0 lines, -117 lines 0 comments Download
D net/test/local_test_server.cc View 1 chunk +0 lines, -252 lines 0 comments Download
D net/test/local_test_server_posix.cc View 1 chunk +0 lines, -180 lines 0 comments Download
D net/test/local_test_server_win.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D net/test/remote_test_server.h View 1 chunk +0 lines, -71 lines 0 comments Download
D net/test/remote_test_server.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D net/test/spawned_test_server.h View 1 chunk +0 lines, -27 lines 0 comments Download
A + net/test/spawned_test_server/base_test_server.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/test/spawned_test_server/base_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/test/spawned_test_server/local_test_server.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + net/test/spawned_test_server/local_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/test/spawned_test_server/local_test_server_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/test/spawned_test_server/local_test_server_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/test/spawned_test_server/remote_test_server.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + net/test/spawned_test_server/remote_test_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + net/test/spawned_test_server/spawned_test_server.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + net/test/spawned_test_server/spawner_communicator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/test/spawned_test_server/spawner_communicator.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/test/spawner_communicator.h View 1 chunk +0 lines, -151 lines 0 comments Download
D net/test/spawner_communicator.cc View 1 chunk +0 lines, -377 lines 0 comments Download
M net/tools/testserver/run_testserver.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_context_builder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M sync/test/local_sync_test_server.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/local_sync_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
After the list of files moved looks OK, I'm going to fix cosmetic issues (gyp ...
7 years, 7 months ago (2013-05-03 19:21:22 UTC) #1
Ryan Hamilton
net/ LGTM. (You're planning to do renames later)
7 years, 7 months ago (2013-05-07 17:57:22 UTC) #2
Avi (use Gerrit)
Drive-by content lgtm stamp
7 years, 7 months ago (2013-05-07 18:03:06 UTC) #3
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-07 20:04:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r198783.

Powered by Google App Engine
This is Rietveld 408576698