[sync] Separate sign in from sync on Desktop Chrome

chrome/browser/signin/signin_tracker_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/signin_tracker.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 91 matching lines @@
       content::Source<Profile>(profile_.get()),
       content::Details<const GoogleServiceAuthError>(&error));
 }
 
 TEST_F(SigninTrackerTest, GaiaSignInSucceeded) {
   // SIGNIN_SUCCEEDED notification should lead us to get a GaiCredentialsValid()
   // callback.
   EXPECT_CALL(observer_, GaiaCredentialsValid());
   EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn())
       .WillRepeatedly(Return(false));
+  const GoogleServiceAuthError error(GoogleServiceAuthError::NONE);
+  EXPECT_CALL(*mock_pss_, GetAuthError()).WillRepeatedly(ReturnRef(error));
   EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
       .WillRepeatedly(Return(false));
   GoogleServiceSigninSuccessDetails details("username@gmail.com", "password");
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL,
       content::Source<Profile>(profile_.get()),
       content::Details<const GoogleServiceSigninSuccessDetails>(&details));
 }
 
 static void ExpectSignedInSyncService(ProfileSyncServiceMock* sync_service,
@@ skipping 110 matching lines @@
 TEST_F(SigninTrackerTest, NoGaiaSigninWhenServicesNotRunning) {
   // SIGNIN_SUCCEEDED notification should not result in a SigninSuccess()
   // callback if we're not already signed in.
   EXPECT_CALL(observer_, GaiaCredentialsValid());
   EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
       .WillRepeatedly(Return(true));
   EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn()).WillRepeatedly(
       Return(false));
   EXPECT_CALL(*mock_pss_, IsSyncTokenAvailable()).WillRepeatedly(
       Return(false));
+  const GoogleServiceAuthError error(GoogleServiceAuthError::NONE);
+  EXPECT_CALL(*mock_pss_, GetAuthError()).WillRepeatedly(ReturnRef(error));
   GoogleServiceSigninSuccessDetails details("username@gmail.com", "password");
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL,
       content::Source<Profile>(profile_.get()),
       content::Details<const GoogleServiceSigninSuccessDetails>(&details));
 }
 
 TEST_F(SigninTrackerTest, GaiaSigninAfterSyncStarts) {
   // Make sure that we don't get a SigninSuccess() callback until after the
   // sync service reports that it's signed in.
   EXPECT_CALL(observer_, GaiaCredentialsValid());
   EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn()).WillOnce(
       Return(false));
+  const GoogleServiceAuthError error(GoogleServiceAuthError::NONE);
+  EXPECT_CALL(*mock_pss_, GetAuthError()).WillRepeatedly(ReturnRef(error));
   EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
       .WillRepeatedly(Return(true));
   mock_signin_manager_->SetAuthenticatedUsername("username@gmail.com");
   GoogleServiceSigninSuccessDetails details("username@gmail.com", "password");
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL,
       content::Source<Profile>(profile_.get()),
       content::Details<const GoogleServiceSigninSuccessDetails>(&details));
   Mock::VerifyAndClearExpectations(mock_pss_);
   // Mimic the sync engine getting credentials.
   EXPECT_CALL(observer_, SigninSuccess());
-  GoogleServiceAuthError error(GoogleServiceAuthError::NONE);
   ExpectSignedInSyncService(mock_pss_, mock_token_service_, error);
   tracker_->OnStateChanged();
 }
 
 TEST_F(SigninTrackerTest, SyncSigninError) {
   // Make sure that we get a SigninFailed() callback if sync gets an error after
-  // initializaiton.
+  // initialization.
   EXPECT_CALL(observer_, GaiaCredentialsValid());
   EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn()).WillRepeatedly(
       Return(false));
   EXPECT_CALL(*mock_pss_, IsSyncTokenAvailable()).WillRepeatedly(
       Return(false));
+  const GoogleServiceAuthError no_error(GoogleServiceAuthError::NONE);
+  EXPECT_CALL(*mock_pss_, GetAuthError()).WillRepeatedly(ReturnRef(no_error));
   EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
       .WillRepeatedly(Return(true));
   mock_signin_manager_->SetAuthenticatedUsername("username@gmail.com");
   GoogleServiceSigninSuccessDetails details("username@gmail.com", "password");
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL,
       content::Source<Profile>(profile_.get()),
       content::Details<const GoogleServiceSigninSuccessDetails>(&details));
 
   // Still waiting for auth, so sync state changes should be ignored.
   EXPECT_CALL(*mock_pss_, waiting_for_auth()).WillOnce(Return(true));
   tracker_->OnStateChanged();
   // Now mimic an auth error - this should cause us to fail (not waiting for
   // auth, but still have no credentials).
   GoogleServiceAuthError error(
       GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS);
   FakeAuthStatusProvider provider(mock_signin_manager_->signin_global_error());
   provider.SetAuthError(error);
   EXPECT_CALL(*mock_pss_, waiting_for_auth()).WillRepeatedly(Return(false));
+  EXPECT_CALL(*mock_pss_, GetAuthError()).WillRepeatedly(ReturnRef(error));
   EXPECT_CALL(observer_, SigninFailed(error));
   tracker_->OnStateChanged();
 }
 
 // Test cases for initial state = SERVICES_INITIALIZING.
 TEST_F(SigninTrackerTest, SigninSuccess) {
   // Reset the |tracker_| and restart with initial state parameter for its
   // constructor later.
   tracker_.reset();
   GoogleServiceAuthError error(GoogleServiceAuthError::NONE);
@@ skipping 54 matching lines @@
 
 TEST_F(SigninTrackerTest, SigninFailedWhenInitializing) {
   tracker_.reset();
   // SigninFailed() should be called.
   GoogleServiceAuthError error(GoogleServiceAuthError::REQUEST_CANCELED);
   EXPECT_CALL(observer_, SigninFailed(error));
   tracker_.reset(new SigninTracker(profile_.get(), &observer_,
                                    SigninTracker::SERVICES_INITIALIZING));
   tracker_->OnStateChanged();
 }