Issue 1469093002: Buildbot fixes after 8c324a5b8d95ae280a1de462c75ff09d6364f17d

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1469093002: Buildbot fixes after 8c324a5b8d95ae280a1de462c75ff09d6364f17d (Closed)

Created:
5 years ago by Paul Berry

Modified:
5 years ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Buildbot fixes after 8c324a5b8d95ae280a1de462c75ff09d6364f17d - Regenerate tasks.dot - Mark a test as passing that previously failed (fail_finalPropertyInducingVariable_classMember_instance_unprefixed) Note that there are three other tests that I would have expected to start passing as well (see fail_finalPropertyInducingVariable_classMember_instance_*), but they still fail. TBR=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ce7625a22c889c6f3eef6b03bf5d19ab99718380

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -40 lines)			Patch
	M	pkg/analyzer/test/generated/resolver_test.dart	View		2 chunks	+12 lines, -12 lines	0 comments	Download
	M	pkg/analyzer/tool/task_dependency_graph/tasks.dot	View		12 chunks	+44 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

Committed patchset #1 (id:1) manually as ce7625a22c889c6f3eef6b03bf5d19ab99718380 (presubmit successful).

5 years ago (2015-11-23 17:04:48 UTC) #1

scheglov

5 years ago (2015-11-23 20:53:11 UTC) #3

Message was sent while issue was closed.

The rest of the tests is fixed now.
https://codereview.chromium.org/1465303002/

Expand Messages | Collapse Messages