Issue 1469063003: Add the --i-like-slow-isolate-spawn flag for those who like slow spawning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1469063003: Add the --i-like-slow-isolate-spawn flag for those who like slow spawning. (Closed)

Created:
5 years ago by turnidge

Modified:
5 years ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add the --i-like-slow-isolate-spawn flag for those who like slow spawning. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/08b3164bf364c72ca19dfc8932ab64a34bc23edb

Patch Set 1 #

Total comments: 2

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -23 lines)			Patch
	M	runtime/lib/isolate.cc	View		3 chunks	+51 lines, -23 lines	2 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

siva

lgtm https://codereview.chromium.org/1469063003/diff/1/runtime/lib/isolate.cc File runtime/lib/isolate.cc (right): https://codereview.chromium.org/1469063003/diff/1/runtime/lib/isolate.cc#newcode236 runtime/lib/isolate.cc:236: Isolate* saved = Isolate::Current(); I think Isolate* saved ...

5 years ago (2015-11-23 20:56:01 UTC) #3

turnidge

5 years ago (2015-11-23 22:18:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
08b3164bf364c72ca19dfc8932ab64a34bc23edb (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages