Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1469063002: Fix unrecoverable SSL interstitials. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unrecoverable SSL interstitials. Unrecoverable SSL errors were broken in Merge 229993, by the upstream CL: https://codereview.chromium.org/23965003/. This fix removes the iOS specific interstitial.mm and uses interstitial_page_impl instead. It also adds support for unrecoverable errors, by returning a DENIED judgment to some errors. BUG=310607 TEST=Go to https://test-sspev.verisign.com/. Clicking on "Revoked" should trigger an unrecoverable error, clicking on "Expired" should trigger a recoverable error (with a "proceed anyway" button) Review URL: https://chromereviews.googleplex.com/12347017 Committed: https://crrev.com/cea915b5bfb88df2fa4b06d8aed7715b9ccc24fe Cr-Commit-Position: refs/heads/master@{#361109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M ios/provider/ios_provider_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/browser_constants.h View 1 chunk +17 lines, -0 lines 0 comments Download
A + ios/public/provider/chrome/browser/browser_constants.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
5 years, 1 month ago (2015-11-23 15:30:56 UTC) #3
droger
lgtm
5 years, 1 month ago (2015-11-23 15:34:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469063002/1
5 years, 1 month ago (2015-11-23 15:35:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 15:42:48 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 15:44:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cea915b5bfb88df2fa4b06d8aed7715b9ccc24fe
Cr-Commit-Position: refs/heads/master@{#361109}

Powered by Google App Engine
This is Rietveld 408576698