Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: mojo/devtools/common/mojo_test

Issue 1469043002: Make `mojo_test` run dart apptests in strict mode by default. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address Ben's offline comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/mojo_test
diff --git a/mojo/devtools/common/mojo_test b/mojo/devtools/common/mojo_test
index b43e95a4d2ef5846708979690ea7099501dab660..d72bb826040951b5ffa7536a35b7868e0ca692b6 100755
--- a/mojo/devtools/common/mojo_test
+++ b/mojo/devtools/common/mojo_test
@@ -39,6 +39,8 @@ variable, containing entries of the following form:
"shell-args": ["--some-flag-for-the-shell", "--another-flag"],
# Optional timeout in seconds, 60 by default.
"timeout": 120,
+ # Optional override for dart content handler strict mode (on by default).
+ "dart_strict_mode": False,
}
|test_list_file| may reference the |target_os| global that will be any of
@@ -51,6 +53,8 @@ _logger = logging.getLogger()
_CACHE_SERVICE_URL = 'mojo:url_response_disk_cache'
_NETWORK_SERVICE_URL = 'mojo:network_service'
+_DART_STRICT_MODE_ARG = ('--args-for=mojo:dart_content_handler '
+ '--enable-strict-mode')
def main():
@@ -88,6 +92,9 @@ def main():
test_args = test_dict.get("test-args", [])
shell_args = test_dict.get("shell-args", []) + common_shell_args
timeout = test_dict.get("timeout", 60)
+ dart_strict_mode = test_dict.get("dart_strict_mode", True)
+ if dart_strict_mode:
+ shell_args.append(_DART_STRICT_MODE_ARG)
_logger.info("Will start: %s" % test_name)
print "Running %s...." % test_name,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698