Issue 1469043002: Make `mojo_test` run dart apptests in strict mode by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1469043002: Make `mojo_test` run dart apptests in strict mode by default. (Closed)

Created:
5 years ago by ppi

Modified:
5 years ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make `mojo_test` run dart apptests in strict mode by default. Fixes https://github.com/domokit/mojo/issues/465. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/48a0095d02936c87c8f041b459d544ff45b878c2

Patch Set 1 #

Patch Set 2 : Address Ben's offline comments. #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	mojo/devtools/common/mojo_test	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

5 years ago (2015-11-23 17:20:08 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
48a0095d02936c87c8f041b459d544ff45b878c2 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages