Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: chrome/common/extensions/features/chrome_channel_feature_filter.cc

Issue 1469003002: Permissions channel filter should use IDS_PRODUCT_NAME (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix includes Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/features/chrome_channel_feature_filter.cc
diff --git a/chrome/common/extensions/features/chrome_channel_feature_filter.cc b/chrome/common/extensions/features/chrome_channel_feature_filter.cc
index d745e07730df1411022c7d1ad81c812d95446436..3613f87243cc93856a20f9e855d99eb893f04eb9 100644
--- a/chrome/common/extensions/features/chrome_channel_feature_filter.cc
+++ b/chrome/common/extensions/features/chrome_channel_feature_filter.cc
@@ -10,8 +10,10 @@
#include "base/lazy_instance.h"
#include "base/strings/stringprintf.h"
#include "chrome/common/extensions/features/feature_channel.h"
+#include "chrome/grit/chromium_strings.h"
#include "components/version_info/version_info.h"
#include "extensions/common/features/simple_feature.h"
+#include "ui/base/l10n/l10n_util.h"
namespace extensions {
@@ -90,9 +92,10 @@ Feature::Availability ChromeChannelFeatureFilter::IsAvailableToManifest(
return Feature::Availability(
Feature::UNSUPPORTED_CHANNEL,
base::StringPrintf(
- "'%s' requires Google Chrome %s channel or newer, but this is the "
- "%s channel.",
- feature()->name().c_str(), GetChannelName(channel_).c_str(),
+ "'%s' requires %s %s channel or newer, but this is the %s channel.",
+ feature()->name().c_str(),
+ l10n_util::GetStringUTF8(IDS_PRODUCT_NAME).c_str(),
+ GetChannelName(channel_).c_str(),
GetChannelName(GetCurrentChannel()).c_str()));
}
return Feature::Availability(Feature::IS_AVAILABLE, std::string());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698