Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 14690014: add bench for blurred rectori case (Closed)

Created:
7 years, 7 months ago by robertphillips
Modified:
7 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Currently, on Windows: rectori 8888: cmsecs = 36.50 GPU: cmsecs = 82.99 gmsecs = 84.72

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -0 lines) Patch
A bench/RectoriBench.cpp View 1 1 chunk +108 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
7 years, 7 months ago (2013-05-10 20:06:01 UTC) #1
bsalomon
lgtm https://codereview.chromium.org/14690014/diff/1/bench/RectoriBench.cpp File bench/RectoriBench.cpp (right): https://codereview.chromium.org/14690014/diff/1/bench/RectoriBench.cpp#newcode19 bench/RectoriBench.cpp:19: enum { private? https://codereview.chromium.org/14690014/diff/1/bench/RectoriBench.cpp#newcode24 bench/RectoriBench.cpp:24: enum { N ...
7 years, 7 months ago (2013-05-10 20:18:22 UTC) #2
robertphillips
7 years, 7 months ago (2013-05-13 14:10:47 UTC) #3
Message was sent while issue was closed.
committed as r9108

https://codereview.chromium.org/14690014/diff/1/bench/RectoriBench.cpp
File bench/RectoriBench.cpp (right):

https://codereview.chromium.org/14690014/diff/1/bench/RectoriBench.cpp#newcode19
bench/RectoriBench.cpp:19: enum {
On 2013/05/10 20:18:22, bsalomon wrote:
> private?

Done.

https://codereview.chromium.org/14690014/diff/1/bench/RectoriBench.cpp#newcode24
bench/RectoriBench.cpp:24: enum { N = SkBENCHLOOP(100) };
On 2013/05/10 20:18:22, bsalomon wrote:
> private?

Done.

https://codereview.chromium.org/14690014/diff/1/bench/RectoriBench.cpp#newcode35
bench/RectoriBench.cpp:35: SkMWCRandom gRandom;
On 2013/05/10 20:18:22, bsalomon wrote:
> this isn't global, maybe drop the g prefix?

Done.

https://codereview.chromium.org/14690014/diff/1/bench/RectoriBench.cpp#newcode73
bench/RectoriBench.cpp:73: private:
On 2013/05/10 20:18:22, bsalomon wrote:
> \n

Done - I think.

Powered by Google App Engine
This is Rietveld 408576698