sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart - Issue 14690009: Make Completers asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

Issue 14690009: Make Completers asynchronous. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

index db10b541fe487444fbcb5c3a8b55274582f348e5..cf639f272800d376d8128b0cef508417a815e84a 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

@@ -614,7 +614,7 @@ class IsolateNatives {

// TODO(sigmund): clean up above, after we make the new API the default:

static spawn(String functionName, String uri, bool isLight) {

- Completer<SendPort> completer = new Completer<SendPort>();

+ Completer<SendPort> completer = new Completer.sync<SendPort>();

ReceivePort port = new ReceivePort();

port.receive((msg, SendPort replyPort) {

port.close();