Make Completers asynchronous.

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
 
 // These values are allowed to be passed directly over the wire.
 bool _isSimpleValue(var value) {
   return (value == null || value is num || value is String || value is bool);
 }
@@ skipping 181 matching lines @@
                                      [Map<Symbol, dynamic> namedArguments]) {
     if (namedArguments != null) {
       throw new UnimplementedError(
           'named argument support is not implemented');
     }
     // Walk the arguments and make sure they are legal.
     for (int i = 0; i < positionalArguments.length; i++) {
       var arg = positionalArguments[i];
       _validateArgument(i, arg);
     }
-    Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
-      completer.complete(
+      return new Future<InstanceMirror>.value(
           _invoke(this, _n(memberName), positionalArguments, true));
     } catch (exception, s) {
-      completer.completeError(exception, s);
+      return new Future<InstanceMirror>.error(exception, s);
     }
-    return completer.future;
   }
 
   Future<InstanceMirror> getFieldAsync(Symbol fieldName) {
-    Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
-      completer.complete(_getField(this, _n(fieldName)));
+      return new Future<InstanceMirror>.value(_getField(this, _n(fieldName)));
     } catch (exception, s) {
-      completer.completeError(exception, s);
+      return new Future<InstanceMirror>.error(exception, s);
     }
-    return completer.future;
   }
 
   Future<InstanceMirror> setFieldAsync(Symbol fieldName, Object arg) {
     _validateArgument(0, arg);
 
-    Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
-      completer.complete(_setField(this, _n(fieldName), arg, true));
+      return new Future<InstanceMirror>.value(
+          _setField(this, _n(fieldName), arg, true));
     } catch (exception, s) {
-      completer.completeError(exception, s);
+      return new Future<InstanceMirror>.error(exception, s);
     }
-    return completer.future;
   }
 
   static _validateArgument(int i, Object arg)
   {
     if (arg is Mirror) {
         if (arg is! InstanceMirror) {
           throw new MirrorException(
               'positional argument $i ($arg) was not an InstanceMirror');
         }
       } else if (!_isSimpleValue(arg)) {
@@ skipping 139 matching lines @@
                                     [Map<Symbol, Object> namedArguments]) {
     if (namedArguments != null) {
       throw new UnimplementedError(
           'named argument support is not implemented');
     }
     // Walk the arguments and make sure they are legal.
     for (int i = 0; i < positionalArguments.length; i++) {
       var arg = positionalArguments[i];
       _LocalObjectMirrorImpl._validateArgument(i, arg);
     }
-    Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
-      completer.complete(
+      return new Future<InstanceMirror>.value(
           _apply(this, positionalArguments, true));
     } catch (exception) {
-      completer.completeError(exception);
+      return new Future<InstanceMirror>.error(exception);
     }
-    return completer.future;
   }
 
   Future<InstanceMirror> findInContext(Symbol name) {
     throw new UnimplementedError(
         'ClosureMirror.findInContext() is not implemented');
   }
 
   static _apply(ref, positionalArguments, async)
       native 'LocalClosureMirrorImpl_apply';
 }
@@ skipping 182 matching lines @@
                                           [Map<Symbol, dynamic> namedArguments]) {
     if (namedArguments != null) {
       throw new UnimplementedError(
           'named argument support is not implemented');
     }
     // Walk the arguments and make sure they are legal.
     for (int i = 0; i < positionalArguments.length; i++) {
       var arg = positionalArguments[i];
       _LocalObjectMirrorImpl._validateArgument(i, arg);
     }
-    Completer<InstanceMirror> completer = new Completer<InstanceMirror>();
     try {
-      completer.complete(
+      return new Future<InstanceMirror>.value(
           _invokeConstructor(this,
                              _n(constructorName),
                              positionalArguments,
                              true));
     } catch (exception) {
-      completer.completeError(exception);
+      return new Future<InstanceMirror>.error(exception);
     }
-    return completer.future;
   }
 
   static _invokeConstructor(ref, constructorName, positionalArguments, async)
       native 'LocalClassMirrorImpl_invokeConstructor';
 }
 
 class _LazyFunctionTypeMirror {
   _LazyFunctionTypeMirror(this.returnType, this.parameters) {}
 
   ClassMirror resolve(MirrorSystem mirrors) {
@@ skipping 417 matching lines @@
 
   // The MirrorSystem for the current isolate.
   static MirrorSystem currentMirrorSystem() {
     if (_currentMirrorSystem == null) {
       _currentMirrorSystem = makeLocalMirrorSystem();
     }
     return _currentMirrorSystem;
   }
 
   static Future<MirrorSystem> mirrorSystemOf(SendPort port) {
-    Completer<MirrorSystem> completer = new Completer<MirrorSystem>();
     if (isLocalPort(port)) {
       // Make a local mirror system.
       try {
-        completer.complete(currentMirrorSystem());
+        return new Future<MirrorSystem>.value(currentMirrorSystem());
       } catch (exception) {
-        completer.completeError(exception);
+        return new Future<MirrorSystem>.error(exception);
       }
     } else {
       // Make a remote mirror system
       throw new UnimplementedError(
           'Remote mirror support is not implemented');
     }
-    return completer.future;
   }
 
   // Creates a new local InstanceMirror
   static InstanceMirror makeLocalInstanceMirror(Object reflectee)
       native 'Mirrors_makeLocalInstanceMirror';
 
   // Creates a new local mirror for some Object.
   static InstanceMirror reflect(Object reflectee) {
     return makeLocalInstanceMirror(reflectee);
   }
 
   // Creates a new local ClassMirror.
   static ClassMirror makeLocalClassMirror(Type key)
       native "Mirrors_makeLocalClassMirror";
 
   static ClassMirror reflectClass(Type key) {
     return makeLocalClassMirror(key);
   }
 }