Make Completers asynchronous.

tests/standalone/io/http_server_early_client_close_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 import "dart:async";
 import "dart:io";
 import "dart:isolate";
 
 void sendData(List<int> data, int port) {
@@ skipping 107 matching lines @@
     makeRequest() {
       Socket.connect("127.0.0.1", server.port).then((socket) {
         var data = "GET / HTTP/1.1\r\nContent-Length: 0\r\n\r\n";
         socket.write(data);
         socket.close();
         socket.done.then((_) {
           socket.destroy();
           if (++count < 10) {
             makeRequest();
           } else {
+            runAsync(server.close);
+          }
+        });
+      });
+    }
+    makeRequest();
+  });
+}
+
+testEarlyClose2b() {

[Anders Johnsen, 2013/05/06 07:44:42]

Florian,

This test is already flaky. We have it tracked in a bug, with a potential fix
underway. Can you add a TODO at the bottom? Thanks!

[floitsch, 2013/05/06 15:14:45]

Extracted it into a separate file and marked it as failing in the status file
(with the bug-number).

+  HttpServer.bind("127.0.0.1", 0).then((server) {
+    server.listen(
+      (request) {
+        String name = new Options().script;
+        new File(name).openRead().pipe(request.response)
+            .catchError((e) { /* ignore */ });
+      });
+
+    var count = 0;
+    makeRequest() {
+      Socket.connect("127.0.0.1", server.port).then((socket) {
+        var data = "GET / HTTP/1.1\r\nContent-Length: 0\r\n\r\n";
+        socket.write(data);
+        socket.close();
+        socket.done.then((_) {
+          socket.destroy();
+          if (++count < 10) {
+            makeRequest();
+          } else {
             server.close();
           }
         });
       });
     }
     makeRequest();
   });
 }
 
 void testEarlyClose3() {
@@ skipping 17 matching lines @@
           socket.close();
           socket.listen((_) {}, onError: (_) {});
           socket.done.catchError((_) {});
         });
   });
 }
 
 void main() {
   testEarlyClose1();
   testEarlyClose2();
+  // testEarlyClose2b();

[Lasse Reichstein Nielsen, 2013/05/06 06:49:11]

Commented code?

[floitsch, 2013/05/06 15:14:45]

I asked Anders to look into it. This test started failing.

   testEarlyClose3();
 }