Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1468993003: [Eraser] Remove chrome://tcmalloc (Closed)

Created:
5 years, 1 month ago by Ruud van Asseldonk
Modified:
5 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org, wfh+watch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, jamesr, rschoen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Eraser] Remove chrome://tcmalloc The chrome://tcmalloc page has been superseded by the memory-infra category of chrome://tracing. The page no longer provides enough value to justify its complexity in the codebase, so unlaunch it in the light of Project Eraser. Furthermore, this allows removing |base::allocator::GetStats|, which is not used anywhere except in chrome:://tcmalloc. Detailed information about memory allocators is available in the memory-infra category of chrome://tracing. Unlike |GetStats|, which was implemented for tcmalloc only, memory-infra provides detailed information about all allocators. BUG=560250 Committed: https://crrev.com/f2ffd5e5b85a66d28f45e21d8d4cc2a221e80403 Cr-Commit-Position: refs/heads/master@{#361402}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Address primiano comment, remove declaration from gpu_child_thread #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -295 lines) Patch
M base/allocator/allocator_extension.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M base/allocator/allocator_extension.cc View 1 2 chunks +0 lines, -15 lines 0 comments Download
M base/allocator/allocator_extension_thunks.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M base/allocator/allocator_extension_thunks.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/content_main_runner.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/histogram_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/profiler_message_filter.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/profiler_message_filter.cc View 3 chunks +0 lines, -11 lines 0 comments Download
D content/browser/tcmalloc_internals_request_job.h View 1 chunk +0 lines, -67 lines 0 comments Download
D content/browser/tcmalloc_internals_request_job.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download
M content/child/child_thread_impl.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 3 chunks +0 lines, -14 lines 0 comments Download
M content/common/child_process_messages.h View 1 2 2 chunks +0 lines, -11 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/url_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Ruud van Asseldonk
jam, wfh, can you please take a look at this cleanup CL?
5 years, 1 month ago (2015-11-23 13:24:24 UTC) #2
jam
lgtm
5 years, 1 month ago (2015-11-23 17:00:31 UTC) #3
Primiano Tucci (use gerrit)
LGTM but you missed to remove one IPC message. https://codereview.chromium.org/1468993003/diff/1/content/common/child_process_messages.h File content/common/child_process_messages.h (right): https://codereview.chromium.org/1468993003/diff/1/content/common/child_process_messages.h#newcode194 content/common/child_process_messages.h:194: ...
5 years ago (2015-11-24 10:18:03 UTC) #5
Ruud van Asseldonk
https://codereview.chromium.org/1468993003/diff/1/content/common/child_process_messages.h File content/common/child_process_messages.h (right): https://codereview.chromium.org/1468993003/diff/1/content/common/child_process_messages.h#newcode194 content/common/child_process_messages.h:194: IPC_MESSAGE_CONTROL1(ChildProcessHostMsg_TcmallocStats, On 2015/11/24 10:18:03, Primiano Tucci wrote: > I ...
5 years ago (2015-11-24 11:10:37 UTC) #6
Will Harris
lgtm but sounds like you already have reviewer coverage.
5 years ago (2015-11-24 18:23:34 UTC) #7
Primiano Tucci (use gerrit)
On 2015/11/24 18:23:34, Will Harris wrote: > lgtm but sounds like you already have reviewer ...
5 years ago (2015-11-24 18:27:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468993003/40001
5 years ago (2015-11-24 18:39:30 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-24 18:50:00 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-24 18:51:18 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f2ffd5e5b85a66d28f45e21d8d4cc2a221e80403
Cr-Commit-Position: refs/heads/master@{#361402}

Powered by Google App Engine
This is Rietveld 408576698