Issue 1468983002: trial_dir: remove files after auto-unmocking stuff.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1468983002: trial_dir: remove files after auto-unmocking stuff. (Closed)

Created:
5 years ago by tandrii(chromium)

Modified:
5 years ago

Reviewers:
phajdan, akuegel, Adrian Kuegel

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/infra/testing/testing_support.git@master

Target Ref:
refs/heads/master

Project:
infra/testing/testing_support

Visibility:
Public.

trial_dir: remove files after auto-unmocking stuff. If a test mocks low level filesystem calls (such as open and listdir), then rmtree of trial_dir will still use the mocks, resulting in spurious test failures. Instead, first auto-unmock things, and then do rm_tree. R=akuegel@chromium.org, akuegel@google.com, phajdan@google.com CC=iannucci@google.com,pgervais@google.com BUG= Committed: https://chromium.googlesource.com/infra/testing/testing_support/+/1208413163890b24836e5b3295147bd2b2cc3fb8

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	testing_support/trial_dir.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Dependent Patchsets:

Total messages: 4 (1 generated)

tandrii(chromium)

5 years ago (2015-11-23 11:20:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1208413163890b24836e5b3295147bd2b2cc3fb8 (presubmit successful).