[release] Merge auto-roll and wrapped chromium-roll scripts.

[release] Merge auto-roll and wrapped chromium-roll scripts.

This replaces chromium_roll and the wrapper auto_roll with
just auto_roll. The arguments for the revision to roll and
the last rolled revision are optional and will be
auto-detected (this feature is from the wrapper).

Checking the cq box is default now (as in the wrapper).

BUG=chromium:559141
LOG=n
NOTRY=true

Committed: https://crrev.com/5aff14adfdb7e9583d7b4dcc8b85ef6d7f8d3ef7
Cr-Commit-Position: refs/heads/master@{#32193}

[Michael Achenbach, 2015-11-23 10:31:26]

Description was changed from

==========
[release] Merge auto-roll and wrapped chromium-roll scripts.

BUG=
==========

to

==========
[release] Merge auto-roll and wrapped chromium-roll scripts.

BUG=chromium:559141
==========

[Michael Achenbach, 2015-11-23 10:36:49]

Description was changed from

==========
[release] Merge auto-roll and wrapped chromium-roll scripts.

BUG=chromium:559141
==========

to

==========
[release] Merge auto-roll and wrapped chromium-roll scripts.

This replaces chromium_roll and the wrapper auto_roll with
just auto_roll. The arguments for the revision to roll and
the last rolled revision are optional and will be
auto-detected (this feature is from the wrapper).

Checking the cq box is default now (as in the wrapper).

BUG=chromium:559141
==========

[Michael Achenbach, 2015-11-23 10:36:49]

machenbach@chromium.org changed reviewers:
+ hablich@chromium.org

[Michael Achenbach, 2015-11-23 10:37:23]

Description was changed from

==========
[release] Merge auto-roll and wrapped chromium-roll scripts.

This replaces chromium_roll and the wrapper auto_roll with
just auto_roll. The arguments for the revision to roll and
the last rolled revision are optional and will be
auto-detected (this feature is from the wrapper).

Checking the cq box is default now (as in the wrapper).

BUG=chromium:559141
==========

to

==========
[release] Merge auto-roll and wrapped chromium-roll scripts.

This replaces chromium_roll and the wrapper auto_roll with
just auto_roll. The arguments for the revision to roll and
the last rolled revision are optional and will be
auto-detected (this feature is from the wrapper).

Checking the cq box is default now (as in the wrapper).

BUG=chromium:559141
LOG=n
NOTRY=true
==========

[Michael Achenbach, 2015-11-23 10:37:30]

PTAL

https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py
File tools/release/auto_roll.py (right):

https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py#...
tools/release/auto_roll.py:10: from common_includes import *
Rietveld is not so helpful here. Better is a diff of the removed chromium_roll
and this file. Everything that appears as new is copied from chromium_roll with
small adjustments, i.e. use the stored roll/last-roll values instead of options
and new option defaults.

[Michael Hablich, 2015-11-24 08:01:34]

On 2015/11/23 10:37:30, Michael Achenbach wrote:
> PTAL
> 
> https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py
> File tools/release/auto_roll.py (right):
> 
>
https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py#...
> tools/release/auto_roll.py:10: from common_includes import *
> Rietveld is not so helpful here. Better is a diff of the removed chromium_roll
> and this file. Everything that appears as new is copied from chromium_roll
with
> small adjustments, i.e. use the stored roll/last-roll values instead of
options
> and new option defaults.

lgtm with a nit

[Michael Achenbach, 2015-11-24 08:21:26]

On 2015/11/24 08:01:34, Hablich wrote:
> On 2015/11/23 10:37:30, Michael Achenbach wrote:
> > PTAL
> > 
> > https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py
> > File tools/release/auto_roll.py (right):
> > 
> >
>
https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py#...
> > tools/release/auto_roll.py:10: from common_includes import *
> > Rietveld is not so helpful here. Better is a diff of the removed
chromium_roll
> > and this file. Everything that appears as new is copied from chromium_roll
> with
> > small adjustments, i.e. use the stored roll/last-roll values instead of
> options
> > and new option defaults.
> 
> lgtm with a nit

Where's the nit?

[Michael Hablich, 2015-11-24 08:22:20]

https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py
File tools/release/auto_roll.py (right):

https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py#...
tools/release/auto_roll.py:179: "Auto-detected by default.")
If there is a default shouldn't default be specified?

[Michael Hablich, 2015-11-24 08:22:46]

On 2015/11/24 08:22:20, Hablich wrote:
> https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py
> File tools/release/auto_roll.py (right):
> 
>
https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py#...
> tools/release/auto_roll.py:179: "Auto-detected by default.")
> If there is a default shouldn't default be specified?

Sorry, hit the wrong button. Nit send now.

[Michael Achenbach, 2015-11-24 08:35:50]

https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py
File tools/release/auto_roll.py (right):

https://codereview.chromium.org/1468973002/diff/1/tools/release/auto_roll.py#...
tools/release/auto_roll.py:179: "Auto-detected by default.")
On 2015/11/24 08:22:20, Hablich wrote:
> If there is a default shouldn't default be specified?

This is a changing value, it can be _any_ hash. Either a hash is provided as
parameter or if not, calculated by the tool. I can do "s/by default/if not
specified" if that makes it clearer.

[Michael Achenbach, 2015-11-24 08:37:39]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2015-11-24 08:37:39]

The patchset sent to the CQ was uploaded after l-g-t-m from hablich@chromium.org
Link to the patchset: https://codereview.chromium.org/1468973002/#ps20001
(title: "Review")

[commit-bot: I haz the power, 2015-11-24 08:37:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1468973002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1468973002/20001

[commit-bot: I haz the power, 2015-11-24 08:39:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-24 08:39:45]

Patchset 2 (id:??) landed as
https://crrev.com/5aff14adfdb7e9583d7b4dcc8b85ef6d7f8d3ef7
Cr-Commit-Position: refs/heads/master@{#32193}