Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1468943002: Remove v8::i::Isolate::Current from cctests (Closed)

Created:
5 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove v8::i::Isolate::Current from cctests BUG=2487 R=yangguo@chromium.org LOG=n Committed: https://crrev.com/0da1a0c068f5c732af90f9788bc06a963ab9d8aa Cr-Commit-Position: refs/heads/master@{#32176}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M test/cctest/test-assembler-arm64.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-assembler-ppc.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M test/cctest/test-code-stubs-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-code-stubs-mips64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-lockers.cc View 1 4 chunks +6 lines, -8 lines 0 comments Download
M test/cctest/test-macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years, 1 month ago (2015-11-23 08:57:56 UTC) #1
Yang
On 2015/11/23 08:57:56, jochen wrote: lgtm once build is fixed.
5 years, 1 month ago (2015-11-23 09:01:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468943002/20001
5 years, 1 month ago (2015-11-23 12:12:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 12:38:31 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 12:38:42 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0da1a0c068f5c732af90f9788bc06a963ab9d8aa
Cr-Commit-Position: refs/heads/master@{#32176}

Powered by Google App Engine
This is Rietveld 408576698