Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1468933002: [test] Switch off perf data feature on swarming. (Closed)

Created:
5 years, 1 month ago by Michael Achenbach
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com, M-A Ruel
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Switch off perf data feature on swarming. The feature sometimes prevents subsequent swarming bots to delete the work directory on windows. The data file is not kept on swarming bots anyways, therefore this switches off the feature completely. BUG=chromium:535160 LOG=n Committed: https://crrev.com/f39d1cd4aa1c790027783484b950b2a860dba849 Cr-Commit-Position: refs/heads/master@{#32168}

Patch Set 1 #

Patch Set 2 : deopt fuzzer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -6 lines) Patch
M tools/run-deopt-fuzzer.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/run-tests.py View 2 chunks +5 lines, -1 line 0 comments Download
M tools/testrunner/local/execution.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testrunner/local/perfdata.py View 1 chunk +26 lines, -0 lines 0 comments Download
M tools/testrunner/objects/context.py View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Michael Achenbach
PTAL
5 years, 1 month ago (2015-11-23 08:48:14 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468933002/20001
5 years, 1 month ago (2015-11-23 08:51:56 UTC) #6
Jakob Kummerow
lgtm
5 years, 1 month ago (2015-11-23 08:52:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468933002/20001
5 years, 1 month ago (2015-11-23 09:07:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 09:10:49 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f39d1cd4aa1c790027783484b950b2a860dba849 Cr-Commit-Position: refs/heads/master@{#32168}
5 years, 1 month ago (2015-11-23 09:11:24 UTC) #12
kjellander_chromium
If "perf data feature" keeps locks on files that causes trouble for other consumers, maybe ...
5 years, 1 month ago (2015-11-23 11:40:36 UTC) #14
Michael Achenbach
5 years, 1 month ago (2015-11-23 12:34:33 UTC) #15
Message was sent while issue was closed.
On 2015/11/23 11:40:36, kjellander (chromium) wrote:
> If "perf data feature" keeps locks on files that causes trouble for other
> consumers, maybe it would be better to track that down and fix?

It happens on windows only and very very rarely. I don't have cycles right now
to dig for this... The suspicious comment is:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/tools/testrunne...

But again: On swarming we can't use the perf data feature anyways as we can't
persist the database file. So I won't fix it for swarming.

Powered by Google App Engine
This is Rietveld 408576698