Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1468913004: Issue 25021. Fix for adding new required parameters when optional exist. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 2 chunks +16 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 1 month ago (2015-11-23 16:31:56 UTC) #1
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-23 17:01:03 UTC) #2
scheglov
5 years, 1 month ago (2015-11-23 17:21:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e05c35650c3935a6245ef406e18ffa5630f71d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698