third_party/WebKit/Source/core/layout/LayoutTheme.h - Issue 1468913002: Find In Page hides the text when text color matches text search hightlight color.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTheme.h

Issue 1468913002: Find In Page hides the text when text color matches text search hightlight color. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added descriptive variable name in function declarations Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/repaint/text-match.html ('K') | « third_party/WebKit/LayoutTests/fast/repaint/text-match-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutTheme.cpp » ('j') | third_party/WebKit/Source/core/layout/line/InlineTextBox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTheme.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutTheme.h b/third_party/WebKit/Source/core/layout/LayoutTheme.h

index 9bee55fef1c8ecd80e77971157bad99b71f76759..ba601a1529dedb9105e2252de5466c9c65bf615f 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTheme.h

+++ b/third_party/WebKit/Source/core/layout/LayoutTheme.h

@@ -116,9 +116,11 @@ public:

Color inactiveListBoxSelectionBackgroundColor() const;

Color inactiveListBoxSelectionForegroundColor() const;

- // Highlighting colors for TextMatches.

+ // Highlighting and text colors for TextMatches.

virtual Color platformActiveTextSearchHighlightColor() const;

pdr. 2015/12/01 23:58:48 Lets make these non-virtual too.

ramya.v 2015/12/10 09:39:37 Done.

virtual Color platformInactiveTextSearchHighlightColor() const;

+ virtual Color platformActiveTextSearchColor() const;

pdr. 2015/12/01 23:58:48 Why are these virtual?

ramya.v 2015/12/10 09:39:37 Done.

+ virtual Color platformInactiveTextSearchColor() const;

pdr. 2015/12/01 23:58:48 Because all callsites have the same ternary statem

ramya.v 2015/12/10 09:39:37 Done.

Color focusRingColor() const;

virtual Color platformFocusRingColor() const { return Color(0, 0, 0); }