third_party/WebKit/Source/core/layout/LayoutTheme.cpp - Issue 1468913002: Find In Page hides the text when text color matches text search hightlight color.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTheme.cpp

Issue 1468913002: Find In Page hides the text when text color matches text search hightlight color. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTheme.h ('k') | third_party/WebKit/Source/core/layout/line/InlineTextBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTheme.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTheme.cpp b/third_party/WebKit/Source/core/layout/LayoutTheme.cpp

index 85b2c3c282090fe7389b2622cbbd8cc1280391f8..08c3e9862fd287a88574d7004428140f9d91b55d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTheme.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTheme.cpp

@@ -815,14 +815,16 @@ Color LayoutTheme::systemColor(CSSValueID cssValueId) const

return Color();

}

-Color LayoutTheme::platformActiveTextSearchHighlightColor() const

+Color LayoutTheme::platformTextSearchHighlightColor(bool activeMatch) const

{

- return Color(255, 150, 50); // Orange.

+ if (activeMatch)

+ return Color(255, 150, 50); // Orange.

+ return Color(255, 255, 0); // Yellow.

}

-Color LayoutTheme::platformInactiveTextSearchHighlightColor() const

+Color LayoutTheme::platformTextSearchColor(bool activeMatch) const

{

- return Color(255, 255, 0); // Yellow.

+ return Color::black;

}

Color LayoutTheme::tapHighlightColor()

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTheme.h ('k') | third_party/WebKit/Source/core/layout/line/InlineTextBox.h » ('j') | no next file with comments »