third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h - Issue 1468913002: Find In Page hides the text when text color matches text search hightlight color.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

Issue 1468913002: Find In Page hides the text when text color matches text search hightlight color. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added testcase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutTheme.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp ('k') | third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

diff --git a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

index 1ef91e49aa308a077a78f30d44a73d746df36e98..0a175f2a79c4a3abb49f4f3b058d9cf7a9589d6c 100644

--- a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

+++ b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

@@ -33,7 +33,7 @@ public:

void paint(const PaintInfo&, const LayoutPoint&);

void paintDocumentMarkers(GraphicsContext*, const LayoutPoint& boxOrigin, const ComputedStyle&, const Font&, bool background);

void paintDocumentMarker(GraphicsContext*, const LayoutPoint& boxOrigin, DocumentMarker*, const ComputedStyle&, const Font&, bool grammar);

- void paintTextMatchMarker(GraphicsContext*, const LayoutPoint& boxOrigin, DocumentMarker*, const ComputedStyle&, const Font&);

+ void paintTextMatchMarker(GraphicsContext*, const LayoutPoint& boxOrigin, DocumentMarker*, const ComputedStyle&, const Font&, bool = true);

rwlbuis 2015/11/30 15:39:52 You'll need a descriptive variable name here, or a

ramya.v 2015/12/01 03:52:41 Done.

static void removeFromTextBlobCache(const InlineTextBox&);