Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp

Issue 1468913002: Find In Page hides the text when text color matches text search hightlight color. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added descriptive variable name in function declarations Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * Copyright (C) 2007 Rob Buis <buis@kde.org> 2 * Copyright (C) 2007 Rob Buis <buis@kde.org>
3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 endPosition = std::min(endPosition, static_cast<int>(fragment.length)); 213 endPosition = std::min(endPosition, static_cast<int>(fragment.length));
214 214
215 return startPosition < endPosition; 215 return startPosition < endPosition;
216 } 216 }
217 217
218 void SVGInlineTextBox::paintDocumentMarker(GraphicsContext*, const LayoutPoint&, DocumentMarker*, const ComputedStyle&, const Font&, bool) const 218 void SVGInlineTextBox::paintDocumentMarker(GraphicsContext*, const LayoutPoint&, DocumentMarker*, const ComputedStyle&, const Font&, bool) const
219 { 219 {
220 // SVG does not have support for generic document markers (e.g., spellchecki ng, etc). 220 // SVG does not have support for generic document markers (e.g., spellchecki ng, etc).
221 } 221 }
222 222
223 void SVGInlineTextBox::paintTextMatchMarker(GraphicsContext* context, const Layo utPoint& point, DocumentMarker* marker, const ComputedStyle& style, const Font& font) const 223 void SVGInlineTextBox::paintTextMatchMarker(GraphicsContext* context, const Layo utPoint& point, DocumentMarker* marker, const ComputedStyle& style, const Font& font, bool) const
224 { 224 {
225 SVGInlineTextBoxPainter(*this).paintTextMatchMarker(context, point, marker, style, font); 225 SVGInlineTextBoxPainter(*this).paintTextMatchMarker(context, point, marker, style, font);
pdr. 2015/12/01 23:58:48 You also need to update this function, SVGInlineTe
ramya.v 2015/12/10 09:39:37 Done.
226 } 226 }
227 227
228 LayoutRect SVGInlineTextBox::calculateBoundaries() const 228 LayoutRect SVGInlineTextBox::calculateBoundaries() const
229 { 229 {
230 LayoutRect textRect; 230 LayoutRect textRect;
231 231
232 LineLayoutSVGInlineText lineLayoutItem = LineLayoutSVGInlineText(this->lineL ayoutItem()); 232 LineLayoutSVGInlineText lineLayoutItem = LineLayoutSVGInlineText(this->lineL ayoutItem());
233 233
234 float scalingFactor = lineLayoutItem.scalingFactor(); 234 float scalingFactor = lineLayoutItem.scalingFactor();
235 ASSERT(scalingFactor); 235 ASSERT(scalingFactor);
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 return true; 282 return true;
283 } 283 }
284 } 284 }
285 } 285 }
286 } 286 }
287 } 287 }
288 return false; 288 return false;
289 } 289 }
290 290
291 } // namespace blink 291 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698