third_party/WebKit/Source/core/layout/line/InlineTextBox.h - Issue 1468913002: Find In Page hides the text when text color matches text search hightlight color.

Side by Side Diff: third_party/WebKit/Source/core/layout/line/InlineTextBox.h

Issue 1468913002: Find In Page hides the text when text color matches text search hightlight color. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added descriptive variable name in function declarations Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/layout/LayoutTheme.h ('K') | « third_party/WebKit/Source/core/layout/LayoutTheme.cpp ('k') | third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * (C) 1999 Lars Knoll (knoll@kde.org)	2 * (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 2000 Dirk Mueller (mueller@kde.org)	3 * (C) 2000 Dirk Mueller (mueller@kde.org)

4 * Copyright (C) 2004, 2005, 2006, 2009, 2010, 2011 Apple Inc. All rights reserv ed.	4 * Copyright (C) 2004, 2005, 2006, 2009, 2010, 2011 Apple Inc. All rights reserv ed.

5 *	5 *

6 * This library is free software; you can redistribute it and/or	6 * This library is free software; you can redistribute it and/or

7 * modify it under the terms of the GNU Library General Public	7 * modify it under the terms of the GNU Library General Public

8 * License as published by the Free Software Foundation; either	8 * License as published by the Free Software Foundation; either

9 * version 2 of the License, or (at your option) any later version.	9 * version 2 of the License, or (at your option) any later version.

10 *	10 *

(...skipping 93 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
104 public:	104 public:

105 TextRun constructTextRunForInspector(const ComputedStyle&, const Font&) cons t;	105 TextRun constructTextRunForInspector(const ComputedStyle&, const Font&) cons t;

106 LayoutRect calculateBoundaries() const override { return LayoutRect(x(), y() , width(), height()); }	106 LayoutRect calculateBoundaries() const override { return LayoutRect(x(), y() , width(), height()); }

107	107

108 virtual LayoutRect localSelectionRect(int startPos, int endPos) const;	108 virtual LayoutRect localSelectionRect(int startPos, int endPos) const;

109 bool isSelected(int startPos, int endPos) const;	109 bool isSelected(int startPos, int endPos) const;

110 void selectionStartEnd(int& sPos, int& ePos) const;	110 void selectionStartEnd(int& sPos, int& ePos) const;

111	111

112 // These functions both paint markers and update the DocumentMarker's render edRect.	112 // These functions both paint markers and update the DocumentMarker's render edRect.

113 virtual void paintDocumentMarker(GraphicsContext, const LayoutPoint& boxOri gin, DocumentMarker, const ComputedStyle&, const Font&, bool grammar) const;	113 virtual void paintDocumentMarker(GraphicsContext, const LayoutPoint& boxOri gin, DocumentMarker, const ComputedStyle&, const Font&, bool grammar) const;

114 virtual void paintTextMatchMarker(GraphicsContext, const LayoutPoint& boxOr igin, DocumentMarker, const ComputedStyle&, const Font&) const;	114 virtual void paintTextMatchMarker(GraphicsContext, const LayoutPoint& boxOr igin, DocumentMarker, const ComputedStyle&, const Font&, bool background = true ) const;
	pdr. 2015/12/01 23:58:48 "bool background" is not a good name, but I have a "bool background" is not a good name, but I have a suggestion below that lets us remove it by splitting this into two functions. ramya.v 2015/12/10 09:39:37 Done. Show quoted text On 2015/12/01 23:58:48, pdr wrote: > "bool background" is not a good name, but I have a suggestion below that lets us > remove it by splitting this into two functions. Done.
115	115

116 void move(const LayoutSize&) final;	116 void move(const LayoutSize&) final;

117	117

118 protected:	118 protected:

119 void paint(const PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutU nit lineBottom) const override;	119 void paint(const PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutU nit lineBottom) const override;

120 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom ) override;	120 bool nodeAtPoint(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom ) override;

121	121

122 private:	122 private:

123 void deleteLine() final;	123 void deleteLine() final;

124 void extractLine() final;	124 void extractLine() final;

(...skipping 57 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
182 }	182 }

183 };	183 };

184	184

185 DEFINE_INLINE_BOX_TYPE_CASTS(InlineTextBox);	185 DEFINE_INLINE_BOX_TYPE_CASTS(InlineTextBox);

186	186

187 void alignSelectionRectToDevicePixels(LayoutRect&);	187 void alignSelectionRectToDevicePixels(LayoutRect&);

188	188

189 } // namespace blink	189 } // namespace blink

190	190

191 #endif // InlineTextBox_h	191 #endif // InlineTextBox_h

OLD	NEW