Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2009)

Unified Diff: content/renderer/mojo_bindings_controller.h

Issue 1468903002: Rename some WebUI Mojo concepts to be more generic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/mojo_bindings_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/mojo_bindings_controller.h
diff --git a/content/renderer/web_ui_mojo.h b/content/renderer/mojo_bindings_controller.h
similarity index 55%
rename from content/renderer/web_ui_mojo.h
rename to content/renderer/mojo_bindings_controller.h
index 5688ec97e9b1f5470ca2738bccec5d9646f8cd41..46ee9c14fa5f51a17b68af316f49d63579b41a00 100644
--- a/content/renderer/web_ui_mojo.h
+++ b/content/renderer/mojo_bindings_controller.h
@@ -2,11 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CONTENT_RENDERER_WEB_UI_MOJO_H_
-#define CONTENT_RENDERER_WEB_UI_MOJO_H_
+#ifndef CONTENT_RENDERER_MOJO_BINDINGS_CONTROLLER_H_
+#define CONTENT_RENDERER_MOJO_BINDINGS_CONTROLLER_H_
#include <string>
+#include "base/macros.h"
#include "content/public/renderer/render_frame_observer.h"
#include "content/public/renderer/render_view_observer.h"
#include "content/public/renderer/render_view_observer_tracker.h"
@@ -18,50 +19,50 @@ class PerContextData;
namespace content {
-class WebUIMojoContextState;
+class MojoContextState;
-// WebUIMojo is responsible for enabling the renderer side of mojo bindings.
-// It creates (and destroys) a WebUIMojoContextState at the appropriate times
-// and handles the necessary browser messages. WebUIMojo destroys itself when
-// the RendererView it is created with is destroyed.
-class WebUIMojo
+// MojoBindingsController is responsible for enabling the renderer side of mojo
+// bindings. It creates (and destroys) a MojoContextState at the appropriate
+// times and handles the necessary browser messages. MojoBindingsController
+// destroys itself when the RendererView it is created with is destroyed.
+class MojoBindingsController
: public RenderViewObserver,
- public RenderViewObserverTracker<WebUIMojo> {
+ public RenderViewObserverTracker<MojoBindingsController> {
public:
- explicit WebUIMojo(RenderView* render_view);
+ explicit MojoBindingsController(RenderView* render_view);
private:
class MainFrameObserver : public RenderFrameObserver {
public:
- explicit MainFrameObserver(WebUIMojo* web_ui_mojo);
+ explicit MainFrameObserver(MojoBindingsController* web_ui_mojo);
~MainFrameObserver() override;
// RenderFrameObserver overrides:
void WillReleaseScriptContext(v8::Local<v8::Context> context,
int world_id) override;
void DidFinishDocumentLoad() override;
- // MainFrameObserver is inline owned by WebUIMojo and should not be
- // destroyed when the main RenderFrame is deleted. Overriding the
+ // MainFrameObserver is inline owned by MojoBindingsController and should
+ // not be destroyed when the main RenderFrame is deleted. Overriding the
// OnDestruct method allows this object to remain alive and be cleaned
- // up as part of WebUIMojo deletion.
+ // up as part of MojoBindingsController deletion.
void OnDestruct() override;
private:
- WebUIMojo* web_ui_mojo_;
+ MojoBindingsController* mojo_bindings_controller_;
DISALLOW_COPY_AND_ASSIGN(MainFrameObserver);
};
- ~WebUIMojo() override;
+ ~MojoBindingsController() override;
void CreateContextState();
void DestroyContextState(v8::Local<v8::Context> context);
// Invoked when the frame finishes loading. Invokes Run() on the
- // WebUIMojoContextState.
+ // MojoContextState.
void OnDidFinishDocumentLoad();
- WebUIMojoContextState* GetContextState();
+ MojoContextState* GetContextState();
// RenderViewObserver overrides:
void DidCreateDocumentElement(blink::WebLocalFrame* frame) override;
@@ -69,9 +70,9 @@ class WebUIMojo
MainFrameObserver main_frame_observer_;
- DISALLOW_COPY_AND_ASSIGN(WebUIMojo);
+ DISALLOW_COPY_AND_ASSIGN(MojoBindingsController);
};
} // namespace content
-#endif // CONTENT_RENDERER_WEB_UI_MOJO_H_
+#endif // CONTENT_RENDERER_MOJO_BINDINGS_CONTROLLER_H_
« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/mojo_bindings_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698