Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3632)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 14689007: Instant Extended: Move omnibox dropdown by 2 pixels (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
index 221a5b988f9b5807f91feae5d1389ea96a91eb6f..7ffb34885b4e39268b291d80f2bf1f88d8001953 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
@@ -374,23 +374,22 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest, ContentOffset) {
OverlayableContentsController* overlay =
[controller() overlayableContentsController];
// Just toolbar.
- EXPECT_EQ(bookmarks::kBookmarkBarOverlap - 1,
- [overlay activeContainerOffset]);
+ EXPECT_EQ(1, [overlay activeContainerOffset]);
// Plus bookmark bar.
browser()->window()->ToggleBookmarkBar();
- EXPECT_EQ(GetViewHeight(VIEW_ID_BOOKMARK_BAR),
- [overlay activeContainerOffset]);
+ CGFloat bookmarkBarOffset =
+ GetViewHeight(VIEW_ID_BOOKMARK_BAR) - bookmarks::kBookmarkBarOverlap + 1;
+ EXPECT_EQ(bookmarkBarOffset, [overlay activeContainerOffset]);
// Plus info bar.
ShowInfoBar();
- EXPECT_EQ(GetViewHeight(VIEW_ID_BOOKMARK_BAR) +
- GetViewHeight(VIEW_ID_INFO_BAR),
+ EXPECT_EQ(bookmarkBarOffset + GetViewHeight(VIEW_ID_INFO_BAR),
[overlay activeContainerOffset]);
// Minus bookmark bar.
browser()->window()->ToggleBookmarkBar();
- EXPECT_EQ(GetViewHeight(VIEW_ID_INFO_BAR) + bookmarks::kBookmarkBarOverlap,
+ EXPECT_EQ(GetViewHeight(VIEW_ID_INFO_BAR) + 1,
[overlay activeContainerOffset]);
}
@@ -453,23 +452,23 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest, ContentOffsetInstantNTP) {
[controller() overlayableContentsController];
// Just toolbar.
- EXPECT_EQ(bookmarks::kBookmarkBarOverlap - 1,
+ EXPECT_EQ(1,
[overlay activeContainerOffset]);
// Plus bookmark bar.
browser()->window()->ToggleBookmarkBar();
- EXPECT_EQ(GetViewHeight(VIEW_ID_BOOKMARK_BAR),
- [overlay activeContainerOffset]);
+ CGFloat bookmarkBarOffset =
+ GetViewHeight(VIEW_ID_BOOKMARK_BAR) - bookmarks::kBookmarkBarOverlap + 1;
+ EXPECT_EQ(bookmarkBarOffset, [overlay activeContainerOffset]);
// Plus info bar.
ShowInfoBar();
- EXPECT_EQ(GetViewHeight(VIEW_ID_BOOKMARK_BAR) +
- GetViewHeight(VIEW_ID_INFO_BAR),
+ EXPECT_EQ(bookmarkBarOffset + GetViewHeight(VIEW_ID_INFO_BAR),
[overlay activeContainerOffset]);
// Minus bookmark bar.
browser()->window()->ToggleBookmarkBar();
- EXPECT_EQ(GetViewHeight(VIEW_ID_INFO_BAR) + bookmarks::kBookmarkBarOverlap,
+ EXPECT_EQ(GetViewHeight(VIEW_ID_INFO_BAR) + 1,
[overlay activeContainerOffset]);
}

Powered by Google App Engine
This is Rietveld 408576698