Remove memory category from chrome://tracing

Remove memory category from chrome://tracing

The tcmalloc heap profiler will be replaced with the heap profiler
in memory-infra. This removes the old "memory" category in
chrome://tracing. (For now, the checkbox still exists in the UI.)

A few places still reference the heap profiling functionality of
tcmalloc. This is left untouched.

Related trace viewer issues:
https://github.com/catapult-project/catapult/issues/1050
https://github.com/catapult-project/catapult/issues/1804

BUG=560300, 524631
TBR=brettw

Committed: https://crrev.com/04511cb6300db2b3cf886bb7d147e1ae72fb8ce6
Cr-Commit-Position: refs/heads/master@{#361903}

[Ruud van Asseldonk, 2015-11-23 16:12:19]

ruuda@google.com changed reviewers:
+ primiano@chromium.org

[ssid, 2015-11-24 14:11:27]

On 2015/11/23 16:12:19, Ruud van Asseldonk wrote:

Oh, I forgot to mention, The tcmalloc profiler gives a hprof dump which can be
processed by gperftools to show different view of profile like callgrind and
call graphs. This is not going to be supported in the new profiler and we will
show only trace viewer view of profile.

[Ruud van Asseldonk, 2015-11-24 15:56:26]

On 2015/11/24 14:11:27, ssid wrote:
> On 2015/11/23 16:12:19, Ruud van Asseldonk wrote:
> 
> Oh, I forgot to mention, The tcmalloc profiler gives a hprof dump which can be
> processed by gperftools to show different view of profile like callgrind and
> call graphs. This is not going to be supported in the new profiler and we will
> show only trace viewer view of profile.

Do you have an example of this? Perhaps we can draw inspiration from it for the
heap profiler. When I tried to run the tcmalloc heap profiler it did not
generate any output at all, and compiling with GN enable_profiling = true or Gyp
profiling=1 resulted in a linker error.

[Primiano Tucci (use gerrit), 2015-11-24 17:57:33]

Can you just remove the "memory" category here and defer the rest to another CL.
I have the feeling that something out there is still relying on the tcmalloc
heap profiler (while I don't have the same feeling about the memory category in
tracing)

[Ruud van Asseldonk, 2015-11-24 19:05:12]

Description was changed from

==========
Remove tcmalloc heap profiler

The tcmalloc heap profiler will be replaced with the heap profiler
in memory-infra. This removes the old "memory" category in
chrome://tracing. (For now, the checkbox still exists in the UI.)

Furthermore, in a few places the tcmalloc heap profiler was used
directly. These have been removed. This allows the
--enable-memory-benchmarking flag to be removed.

BUG=560300
==========

to

==========
Remove memory category from chrome://tracing

The tcmalloc heap profiler will be replaced with the heap profiler
in memory-infra. This removes the old "memory" category in
chrome://tracing. (For now, the checkbox still exists in the UI.)

A few places still reference the heap profiling functionality of
tcmalloc. This is left untouched.

BUG=560300, 524631
==========

[Ruud van Asseldonk, 2015-11-24 19:05:44]

On 2015/11/24 17:57:33, Primiano Tucci wrote:
> Can you just remove the "memory" category here and defer the rest to another
CL.
> I have the feeling that something out there is still relying on the tcmalloc
> heap profiler (while I don't have the same feeling about the memory category
in
> tracing)

Done, please take another look.

[Primiano Tucci (use gerrit), 2015-11-25 12:16:26]

primiano@chromium.org changed reviewers:
+ brettw@chromium.org, jochen@chromium.org, nduca@chromium.org

[Primiano Tucci (use gerrit), 2015-11-25 12:16:27]

LGTM, thanks for the cleanup

+jochen for removing a bunch of lines in content/{browser,child}

+brettw for one line change to 	tools/gn/bootstrap/bootstrap.py

+oystene FYI, hope you don't mind cleaning up trace_event_common.h :)

+nduca FYI we are removing the old "memory" category as discussed in
crbug.com/486981. Rationale: we are close to the point to have a replacement
ready. However we need to do some global cleanup (pay the technical debt of the
messy situation of allocator.gyp) and mantaining the old memory category that is
going away is a pain at this point and not worth it.

[jochen (gone - plz use gerrit), 2015-11-25 12:25:55]

lgtm

[Ruud van Asseldonk, 2015-11-25 16:10:29]

Description was changed from

==========
Remove memory category from chrome://tracing

The tcmalloc heap profiler will be replaced with the heap profiler
in memory-infra. This removes the old "memory" category in
chrome://tracing. (For now, the checkbox still exists in the UI.)

A few places still reference the heap profiling functionality of
tcmalloc. This is left untouched.

BUG=560300, 524631
==========

to

==========
Remove memory category from chrome://tracing

The tcmalloc heap profiler will be replaced with the heap profiler
in memory-infra. This removes the old "memory" category in
chrome://tracing. (For now, the checkbox still exists in the UI.)

A few places still reference the heap profiling functionality of
tcmalloc. This is left untouched.

Related trace viewer issues:
https://github.com/catapult-project/catapult/issues/1050
https://github.com/catapult-project/catapult/issues/1804

BUG=560300, 524631
==========

[Primiano Tucci (use gerrit), 2015-11-26 16:22:29]

I suggest to TBR brettw as this is really just a cleanup and the missing OWNERS
coverage at this point is:
- just removing one include from "tools/gn/bootstrap/bootstrap.py"
- removing one argument from the macro in TRACE_EVENT_WITH_MEMORY_TAG2 (which is
more a tracing thing)

And MTV is OOO until next Monday.

[Ruud van Asseldonk, 2015-11-26 16:23:49]

Description was changed from

==========
Remove memory category from chrome://tracing

The tcmalloc heap profiler will be replaced with the heap profiler
in memory-infra. This removes the old "memory" category in
chrome://tracing. (For now, the checkbox still exists in the UI.)

A few places still reference the heap profiling functionality of
tcmalloc. This is left untouched.

Related trace viewer issues:
https://github.com/catapult-project/catapult/issues/1050
https://github.com/catapult-project/catapult/issues/1804

BUG=560300, 524631
==========

to

==========
Remove memory category from chrome://tracing

The tcmalloc heap profiler will be replaced with the heap profiler
in memory-infra. This removes the old "memory" category in
chrome://tracing. (For now, the checkbox still exists in the UI.)

A few places still reference the heap profiling functionality of
tcmalloc. This is left untouched.

Related trace viewer issues:
https://github.com/catapult-project/catapult/issues/1050
https://github.com/catapult-project/catapult/issues/1804

BUG=560300, 524631
TBR=brettw
==========

[Ruud van Asseldonk, 2015-11-26 16:24:00]

The CQ bit was checked by ruuda@google.com

[commit-bot: I haz the power, 2015-11-26 16:24:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1468883003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1468883003/40001

[commit-bot: I haz the power, 2015-11-26 16:30:01]

Description was changed from

==========
Remove memory category from chrome://tracing

The tcmalloc heap profiler will be replaced with the heap profiler
in memory-infra. This removes the old "memory" category in
chrome://tracing. (For now, the checkbox still exists in the UI.)

A few places still reference the heap profiling functionality of
tcmalloc. This is left untouched.

Related trace viewer issues:
https://github.com/catapult-project/catapult/issues/1050
https://github.com/catapult-project/catapult/issues/1804

BUG=560300, 524631
TBR=brettw
==========

to

==========
Remove memory category from chrome://tracing

The tcmalloc heap profiler will be replaced with the heap profiler
in memory-infra. This removes the old "memory" category in
chrome://tracing. (For now, the checkbox still exists in the UI.)

A few places still reference the heap profiling functionality of
tcmalloc. This is left untouched.

Related trace viewer issues:
https://github.com/catapult-project/catapult/issues/1050
https://github.com/catapult-project/catapult/issues/1804

BUG=560300, 524631
TBR=brettw
==========

[commit-bot: I haz the power, 2015-11-26 16:30:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-26 16:31:19]

Description was changed from

==========
Remove memory category from chrome://tracing

The tcmalloc heap profiler will be replaced with the heap profiler
in memory-infra. This removes the old "memory" category in
chrome://tracing. (For now, the checkbox still exists in the UI.)

A few places still reference the heap profiling functionality of
tcmalloc. This is left untouched.

Related trace viewer issues:
https://github.com/catapult-project/catapult/issues/1050
https://github.com/catapult-project/catapult/issues/1804

BUG=560300, 524631
TBR=brettw
==========

to

==========
Remove memory category from chrome://tracing

The tcmalloc heap profiler will be replaced with the heap profiler
in memory-infra. This removes the old "memory" category in
chrome://tracing. (For now, the checkbox still exists in the UI.)

A few places still reference the heap profiling functionality of
tcmalloc. This is left untouched.

Related trace viewer issues:
https://github.com/catapult-project/catapult/issues/1050
https://github.com/catapult-project/catapult/issues/1804

BUG=560300, 524631
TBR=brettw

Committed: https://crrev.com/04511cb6300db2b3cf886bb7d147e1ae72fb8ce6
Cr-Commit-Position: refs/heads/master@{#361903}
==========

[commit-bot: I haz the power, 2015-11-26 16:31:20]

Patchset 3 (id:??) landed as
https://crrev.com/04511cb6300db2b3cf886bb7d147e1ae72fb8ce6
Cr-Commit-Position: refs/heads/master@{#361903}