Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1468873002: metrics: Wrap leak detector sources in Chrome OS condition (Closed)

Created:
5 years, 1 month ago by Simon Que
Modified:
5 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

metrics: Wrap leak detector sources in Chrome OS condition Even though the leak_detector sources are only dependencies of components_unittests if chromeos==1, they would still be built for the "all" target, i.e. "ninja -C out/Release all" The solution is to wrap the original sources in a condition for Chrome OS. BUG=382705 Signed-off-by: Simon Que <sque@chromium.org>;

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -57 lines) Patch
M components/metrics.gypi View 2 chunks +28 lines, -23 lines 0 comments Download
M components/metrics/BUILD.gn View 2 chunks +38 lines, -34 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Simon Que
5 years, 1 month ago (2015-11-22 20:43:10 UTC) #2
sigbjorn
5 years, 1 month ago (2015-11-23 08:33:47 UTC) #3
I presume you meant sigbjornf, not me? (I don't have edit rights, so can't fix.)

Powered by Google App Engine
This is Rietveld 408576698